titan/soteria
3
0
Fork 0
Code Issues 23 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

WIP: The prior commit (51133b5) on this PR added the cachePath constant but never updated the three call sites that still used the raw "/cache" literal. I replaced all three: the two corev1.VolumeMount MountPath fields (in buildBackupJob and b #3

Draft
bstein wants to merge 2 commits from hermes-repair/sonar-AZ9pTqVcN0JrBQvDGDs3 into main
pull from: hermes-repair/sonar-AZ9pTqVcN0JrBQvDGDs3
merge into: titan:main
Conversation 0 Commits 2 Files Changed 1 +5 -3
bstein commented 2026-08-07 05:18:55 +00:00
Owner
Copy Link

{
"artifacts": [
"commit f21833e on branch hermes-repair/sonar-AZ9pTqVcN0JrBQvDGDs3"
],
"blockers": [],
"changed_files": [
"internal/k8s/job_manifests.go"
],
"findings": [
"Prior commit 51133b5 only added the cachePath const and never replaced any of the three /cache literal call sites, despite its commit message claiming it did \u2014 this commit completes that work.",
"gofmt and go test ./internal/k8s/... could not be run: no go/gofmt binary and no reachable Docker daemon in this sandbox. Change was verified by manual inspection (simple literal-to-identifier substitution, same indentation/formatting)."
],
"status": "completed",
"summary": "The prior commit (51133b5) on this PR added the cachePath constant but never updated the three call sites that still used the raw "/cache" literal. I replaced all three: the two corev1.VolumeMount MountPath fields (in buildBackupJob and buildRestoreJob) and the RESTIC_CACHE_DIR env Value in resticEnv, all in internal/k8s/job_manifests.go. This is a pure identifier substitution \u2014 no behavior change. Committed locally as f21833e on the existing branch hermes-repair/sonar-AZ9pTqVcN0JrBQvDGDs3. Verified via grep that no remaining \"/cache\" literals exist outside the const declaration itself. No Go toolchain (go/gofmt) or Docker daemon is available in this sandbox, so gofmt and go test could not be executed directly; the diff is a minimal same-indentation literal\u2192identifier swap that is gofmt-safe by inspection. Per the run's boundary, I do not have SCM credentials to push or update the PR \u2014 that step is left to the worker boundary/mediator.",
"tests_run": []
}

{ "artifacts": [ "commit f21833e on branch hermes-repair/sonar-AZ9pTqVcN0JrBQvDGDs3" ], "blockers": [], "changed_files": [ "internal/k8s/job_manifests.go" ], "findings": [ "Prior commit 51133b5 only added the cachePath const and never replaced any of the three /cache literal call sites, despite its commit message claiming it did \u2014 this commit completes that work.", "gofmt and `go test ./internal/k8s/...` could not be run: no `go`/`gofmt` binary and no reachable Docker daemon in this sandbox. Change was verified by manual inspection (simple literal-to-identifier substitution, same indentation/formatting)." ], "status": "completed", "summary": "The prior commit (51133b5) on this PR added the `cachePath` constant but never updated the three call sites that still used the raw \"/cache\" literal. I replaced all three: the two corev1.VolumeMount MountPath fields (in buildBackupJob and buildRestoreJob) and the RESTIC_CACHE_DIR env Value in resticEnv, all in internal/k8s/job_manifests.go. This is a pure identifier substitution \u2014 no behavior change. Committed locally as f21833e on the existing branch hermes-repair/sonar-AZ9pTqVcN0JrBQvDGDs3. Verified via grep that no remaining `\"/cache\"` literals exist outside the const declaration itself. No Go toolchain (go/gofmt) or Docker daemon is available in this sandbox, so gofmt and `go test` could not be executed directly; the diff is a minimal same-indentation literal\u2192identifier swap that is gofmt-safe by inspection. Per the run's boundary, I do not have SCM credentials to push or update the PR \u2014 that step is left to the worker boundary/mediator.", "tests_run": [] }
bstein added 1 commit 2026-08-07 05:18:57 +00:00
hermes-automation added 1 commit 2026-09-14 01:22:39 +00:00 
The prior commit introduced the cachePath constant but never updated its
call sites. Replace the two VolumeMount MountPath literals and the
RESTIC_CACHE_DIR env value with cachePath to finish deduplicating the
Sonar-flagged repeated string literal.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
hermes-automation changed title from fix(hermes): repair sonar/soteria/go:S1192/AZ9pTqVcN0JrBQvDGDs3 to WIP: The prior commit (51133b5) on this PR added the `cachePath` constant but never updated the three call sites that still used the raw "/cache" literal. I replaced all three: the two corev1.VolumeMount MountPath fields (in buildBackupJob and b 2026-09-14 01:22:40 +00:00
This pull request is marked as a work in progress.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hermes-repair/sonar-AZ9pTqVcN0JrBQvDGDs3:hermes-repair/sonar-AZ9pTqVcN0JrBQvDGDs3
git checkout hermes-repair/sonar-AZ9pTqVcN0JrBQvDGDs3
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
atlas-reconciler bstein hermes-automation
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: titan/soteria#3
No description provided.
Delete Branch "hermes-repair/sonar-AZ9pTqVcN0JrBQvDGDs3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?