titan/metis
3
0
Fork 0
Code Issues 7 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

fix(hermes): repair sonar/metis/go:S1192/AZ2z_XbvKy9i4pkIqvM- #2

Open
bstein wants to merge 1 commits from hermes-repair/sonar-AZ2z_XbvKy9i4pkIqvM into master
pull from: hermes-repair/sonar-AZ2z_XbvKy9i4pkIqvM
merge into: titan:master
Conversation 0 Commits 1 Files Changed 1 +2
bstein commented 2026-08-07 09:18:46 +00:00
Owner
Copy Link

Hermes repair proposal for incident sonar/metis/go:S1192/AZ2z_XbvKy9i4pkIqvM-

Incident: sonar/metis/go:S1192/AZ2z_XbvKy9i4pkIqvM-
File: cmd/metis/remote_artifacts.go
SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=metis&open=AZ2z_XbvKy9i4pkIqvM-
Analysis: The literal "%w: %s" is duplicated in four oras command error paths. A package-level constant removes the duplication while preserving the exact error formatting and behavior.
Rationale: Define the duplicated format string once, then replace each of the four fmt.Errorf format literals with orasCommandErrorFormat. This is a localized behavior-preserving Sonar S1192 fix.
Hermes run: run_284a37b1c28c4611a9f2d4587095aa20
That link opens the run itself: the prompt Hermes was given, the evidence bundle it read, the tools it called, and the JSON it returned.

Proposed by Hermes; validated and pushed by Ariadne; requires human review — no automatic merge.

## Hermes repair proposal for incident sonar/metis/go:S1192/AZ2z_XbvKy9i4pkIqvM- **Incident:** sonar/metis/go:S1192/AZ2z_XbvKy9i4pkIqvM- **File:** `cmd/metis/remote_artifacts.go` **SonarQube finding:** https://quality.bstein.dev/project/issues?resolved=false&id=metis&open=AZ2z_XbvKy9i4pkIqvM- **Analysis:** The literal "%w: %s" is duplicated in four oras command error paths. A package-level constant removes the duplication while preserving the exact error formatting and behavior. **Rationale:** Define the duplicated format string once, then replace each of the four fmt.Errorf format literals with orasCommandErrorFormat. This is a localized behavior-preserving Sonar S1192 fix. **Hermes run:** [run_284a37b1c28c4611a9f2d4587095aa20](https://agent.bstein.dev/chat?resume=run_284a37b1c28c4611a9f2d4587095aa20) That link opens the run itself: the prompt Hermes was given, the evidence bundle it read, the tools it called, and the JSON it returned. Proposed by Hermes; validated and pushed by Ariadne; requires human review — no automatic merge.
bstein added 1 commit 2026-08-07 09:18:50 +00:00
This pull request doesn't have enough required approvals yet. 0 of 1 approvals granted from users or teams on the allowlist.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hermes-repair/sonar-AZ2z_XbvKy9i4pkIqvM:hermes-repair/sonar-AZ2z_XbvKy9i4pkIqvM
git checkout hermes-repair/sonar-AZ2z_XbvKy9i4pkIqvM
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
atlas-reconciler bstein hermes-automation
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: titan/metis#2
No description provided.
Delete Branch "hermes-repair/sonar-AZ2z_XbvKy9i4pkIqvM"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?