bstein/atlasbot
1
0
Fork 0
Code Issues 2 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

fix(hermes): repair sonar/atlasbot/python:S1192/AZ2y3T38Ky9i4pkIpSiU #6

Open
bstein wants to merge 1 commits from hermes-repair/sonar-AZ2y3T38Ky9i4pkIpSiU into main
pull from: hermes-repair/sonar-AZ2y3T38Ky9i4pkIpSiU
merge into: bstein:main
Conversation 0 Commits 1 Files Changed 1 +4 -1
bstein commented 2026-08-08 03:18:00 +00:00
Owner
Copy Link

Hermes repair proposal for incident sonar/atlasbot/python:S1192/AZ2y3T38Ky9i4pkIpSiU

Incident: sonar/atlasbot/python:S1192/AZ2y3T38Ky9i4pkIpSiU
File: atlasbot/engine/answerer/spine.py
SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T38Ky9i4pkIpSiU
Analysis: The literal "nodes:" is duplicated in _spine_nodes and _spine_fallback. Introduce one module-level constant and use it at all three call sites, preserving all matching behavior.
Rationale: Use the shared constant for the remaining two "nodes:" entries in _spine_fallback: (_NODES_PREFIX, "nodes_total:") and (_NODES_PREFIX, "nodes_ready:"). This removes the duplicated literal without changing matching behavior.
Hermes run: run_6453735b72bc4858ac7ac0c6fdab36ca
That link opens the run itself: the prompt Hermes was given, the evidence bundle it read, the tools it called, and the JSON it returned.

Proposed by Hermes; validated and pushed by Ariadne; requires human review — no automatic merge.

## Hermes repair proposal for incident sonar/atlasbot/python:S1192/AZ2y3T38Ky9i4pkIpSiU **Incident:** sonar/atlasbot/python:S1192/AZ2y3T38Ky9i4pkIpSiU **File:** `atlasbot/engine/answerer/spine.py` **SonarQube finding:** https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T38Ky9i4pkIpSiU **Analysis:** The literal "nodes:" is duplicated in _spine_nodes and _spine_fallback. Introduce one module-level constant and use it at all three call sites, preserving all matching behavior. **Rationale:** Use the shared constant for the remaining two "nodes:" entries in _spine_fallback: (_NODES_PREFIX, "nodes_total:") and (_NODES_PREFIX, "nodes_ready:"). This removes the duplicated literal without changing matching behavior. **Hermes run:** [run_6453735b72bc4858ac7ac0c6fdab36ca](https://agent.bstein.dev/chat?resume=run_6453735b72bc4858ac7ac0c6fdab36ca) That link opens the run itself: the prompt Hermes was given, the evidence bundle it read, the tools it called, and the JSON it returned. Proposed by Hermes; validated and pushed by Ariadne; requires human review — no automatic merge.
bstein added 1 commit 2026-08-08 03:18:01 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hermes-repair/sonar-AZ2y3T38Ky9i4pkIpSiU:hermes-repair/sonar-AZ2y3T38Ky9i4pkIpSiU
git checkout hermes-repair/sonar-AZ2y3T38Ky9i4pkIpSiU
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bstein
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bstein/atlasbot#6
No description provided.
Delete Branch "hermes-repair/sonar-AZ2y3T38Ky9i4pkIpSiU"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?