bstein/ariadne
1
0
Fork 0
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(hermes): repair sonar/ariadne/AZ2y0FYFKy9i4pkIpNlV #6

Open
bstein wants to merge 1 commits from hermes-repair/sonar-AZ2y0FYFKy9i4pkIpNlV into master
pull from: hermes-repair/sonar-AZ2y0FYFKy9i4pkIpNlV
merge into: bstein:master
Conversation 0 Commits 1 Files Changed 1 +1 -1
bstein commented 2026-08-07 02:17:23 +00:00
Owner
Copy Link

Hermes repair proposal for incident sonar/ariadne/python:S2208/AZ2y0FYFKy9i4pkIpNlV

Incident: sonar/ariadne/python:S2208/AZ2y0FYFKy9i4pkIpNlV
File: ariadne/services/cluster_state_profiles.py
SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=ariadne&open=AZ2y0FYFKy9i4pkIpNlV
Analysis: The S2208 finding is caused by the wildcard import. This module uses _NODE_WORKLOAD_TOP, _PROFILE_LIMIT, ClusterStateSummary, and SignalContext from cluster_state_contract; importing those names explicitly preserves the existing runtime behavior and all contents relevant to this module.
Rationale: Replace the wildcard import with the exact contract symbols used by this module, resolving python:S2208 without changing behavior.
Hermes run: run_15782a0dc4584b3cb949734d3d0c0ba1
That link opens the run itself: the prompt Hermes was given, the evidence bundle it read, the tools it called, and the JSON it returned.

Proposed by Hermes; validated and pushed by Ariadne; requires human review — no automatic merge.

Both links are real and will resolve. Two things worth knowing before you demo it:

The run id is genuine but not the original. PR #6 was opened before run ids were recorded in the current format, so that event is gone. run_15782a0dc4584b3cb949734d3d0c0ba1 is a real Hermes run for this exact finding, from 13:17 today — one of the hourly retries. It produced the same analysis; it just couldn't push because the branch already exists. So the link opens a true run for this finding, which is why I picked it over inventing one. If someone asks "is that the run that made this PR?", the honest answer is "it's today's run for this finding — the original predates run-id capture."

The incident id gains the rule. I used the current format (.../python:S2208/AZ2y...), which is what makes the title and the SonarQube link line up. The PR title still shows the old form; if you want them consistent, retitle to:

fix(hermes): repair sonar/ariadne/python:S2208/AZ2y0FYFKy9i4pkIpNlV

That also matters mechanically — the rule-level dedupe reads the rule out of the PR title, so with the old title the sweep can't see that python:S2208 is already under review. That's precisely why it's retried and 422'd every hour since 08:19. Retitling stops that.

## Hermes repair proposal for incident sonar/ariadne/python:S2208/AZ2y0FYFKy9i4pkIpNlV **Incident:** sonar/ariadne/python:S2208/AZ2y0FYFKy9i4pkIpNlV **File:** `ariadne/services/cluster_state_profiles.py` **SonarQube finding:** https://quality.bstein.dev/project/issues?resolved=false&id=ariadne&open=AZ2y0FYFKy9i4pkIpNlV **Analysis:** The S2208 finding is caused by the wildcard import. This module uses _NODE_WORKLOAD_TOP, _PROFILE_LIMIT, ClusterStateSummary, and SignalContext from cluster_state_contract; importing those names explicitly preserves the existing runtime behavior and __all__ contents relevant to this module. **Rationale:** Replace the wildcard import with the exact contract symbols used by this module, resolving python:S2208 without changing behavior. **Hermes run:** [run_15782a0dc4584b3cb949734d3d0c0ba1](https://agent.bstein.dev/chat?resume=run_15782a0dc4584b3cb949734d3d0c0ba1) That link opens the run itself: the prompt Hermes was given, the evidence bundle it read, the tools it called, and the JSON it returned. Proposed by Hermes; validated and pushed by Ariadne; requires human review — no automatic merge. Both links are real and will resolve. Two things worth knowing before you demo it: The run id is genuine but not the original. PR #6 was opened before run ids were recorded in the current format, so that event is gone. run_15782a0dc4584b3cb949734d3d0c0ba1 is a real Hermes run for this exact finding, from 13:17 today — one of the hourly retries. It produced the same analysis; it just couldn't push because the branch already exists. So the link opens a true run for this finding, which is why I picked it over inventing one. If someone asks "is that the run that made this PR?", the honest answer is "it's today's run for this finding — the original predates run-id capture." The incident id gains the rule. I used the current format (.../python:S2208/AZ2y...), which is what makes the title and the SonarQube link line up. The PR title still shows the old form; if you want them consistent, retitle to: fix(hermes): repair sonar/ariadne/python:S2208/AZ2y0FYFKy9i4pkIpNlV That also matters mechanically — the rule-level dedupe reads the rule out of the PR title, so with the old title the sweep can't see that python:S2208 is already under review. That's precisely why it's retried and 422'd every hour since 08:19. Retitling stops that.
bstein added 1 commit 2026-08-07 02:17:25 +00:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hermes-repair/sonar-AZ2y0FYFKy9i4pkIpNlV:hermes-repair/sonar-AZ2y0FYFKy9i4pkIpNlV
git checkout hermes-repair/sonar-AZ2y0FYFKy9i4pkIpNlV
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bstein
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bstein/ariadne#6
No description provided.
Delete Branch "hermes-repair/sonar-AZ2y0FYFKy9i4pkIpNlV"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?