[hermes] soteria: go:S1192 #89

New Issue

hermes-automation · 2026-10-24T12:24:36Z

hermes-automation commented

2026-10-24 12:24:36 +00:00

SonarQube reports go:S1192 in internal/k8s/job_manifests.go. The build is green; this is a standing finding, not a failure.

What is wrong

The literal "/cache" is duplicated for the backup mount, restore mount, and RESTIC_CACHE_DIR environment variable. Define one package-level constant and use it at those sites so the cache path remains consistent without changing behavior.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Define a constant instead of duplicating this literal "/cache" 3 times. (CRITICAL, 6min estimated) (internal/k8s/job_manifests.go:45)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

internal/k8s/job_manifests.go — Add a named constant for the Restic cache mount path and replace the three identical literal values with it. This resolves S1192 while preserving the generated Kubernetes job manifests and environment exactly.

const resticCacheMountPath = "/cache"

// In buildBackupJob:
{Name: "cache", MountPath: resticCacheMountPath},

// In buildRestoreJob:
{Name: "cache", MountPath: resticCacheMountPath},

// In resticEnv:
{Name: "RESTIC_CACHE_DIR", Value: resticCacheMountPath},

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=soteria&open=AZ9pTqVcN0JrBQvDGDs3
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_5a5690170f494b74a8be272353e93610). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **go:S1192** in `internal/k8s/job_manifests.go`. The build is green; this is a standing finding, not a failure. ## What is wrong The literal "/cache" is duplicated for the backup mount, restore mount, and RESTIC_CACHE_DIR environment variable. Define one package-level constant and use it at those sites so the cache path remains consistent without changing behavior. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Define a constant instead of duplicating this literal "/cache" 3 times. (CRITICAL, 6min estimated) (`internal/k8s/job_manifests.go:45`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`internal/k8s/job_manifests.go`** — Add a named constant for the Restic cache mount path and replace the three identical literal values with it. This resolves S1192 while preserving the generated Kubernetes job manifests and environment exactly. ``` const resticCacheMountPath = "/cache" // In buildBackupJob: {Name: "cache", MountPath: resticCacheMountPath}, // In buildRestoreJob: {Name: "cache", MountPath: resticCacheMountPath}, // In resticEnv: {Name: "RESTIC_CACHE_DIR", Value: resticCacheMountPath}, ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=soteria&open=AZ9pTqVcN0JrBQvDGDs3 - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_5a5690170f494b74a8be272353e93610](https://triage.bstein.dev/chat?resume=run_5a5690170f494b74a8be272353e93610)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: titan/soteria#89