[hermes] soteria: go:S1192 #66

New Issue

hermes-automation · 2026-09-29T12:35:34Z

hermes-automation commented

2026-09-29 12:35:34 +00:00

SonarQube reports go:S1192 in internal/k8s/job_manifests.go. The build is green; this is a standing finding, not a failure.

What is wrong

The string literal "/cache" is duplicated three times in job_manifests.go: as the cache VolumeMount path in buildBackupJob, as the cache VolumeMount path in buildRestoreJob, and as the RESTIC_CACHE_DIR value in resticEnv. If the cache mount path ever changes, all three sites must be updated in lockstep, which is exactly the drift risk go:S1192 flags.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Define a constant instead of duplicating this literal "/cache" 3 times. (CRITICAL, 6min estimated) (internal/k8s/job_manifests.go:45)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

internal/k8s/job_manifests.go — Introduce a package-level constant for the restic cache directory and use it at the three sites that currently repeat the literal. The constant's value is identical to the current literal, so the generated manifests are byte-for-byte unchanged. (The "/cache/restore" paths inside restoreCommand are a different literal and are intentionally left as-is to keep the shell command string identical.)

// Add near the top of the file, after the imports:
const resticCacheDir = "/cache"

// In buildBackupJob, replace the container VolumeMounts with:
				VolumeMounts: []corev1.VolumeMount{
					{Name: "data", MountPath: "/data", ReadOnly: true},
					{Name: "cache", MountPath: resticCacheDir},
				},

// In buildRestoreJob, replace the container VolumeMounts with:
				VolumeMounts: []corev1.VolumeMount{
					{Name: "restore", MountPath: "/restore"},
					{Name: "cache", MountPath: resticCacheDir},
				},

// In resticEnv, replace the RESTIC_CACHE_DIR entry with:
		{Name: "RESTIC_CACHE_DIR", Value: resticCacheDir},

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=soteria&open=AZ9pTqVcN0JrBQvDGDs3
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_d2898bceac7e441599e92e792edca69c). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **go:S1192** in `internal/k8s/job_manifests.go`. The build is green; this is a standing finding, not a failure. ## What is wrong The string literal "/cache" is duplicated three times in job_manifests.go: as the cache VolumeMount path in buildBackupJob, as the cache VolumeMount path in buildRestoreJob, and as the RESTIC_CACHE_DIR value in resticEnv. If the cache mount path ever changes, all three sites must be updated in lockstep, which is exactly the drift risk go:S1192 flags. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Define a constant instead of duplicating this literal "/cache" 3 times. (CRITICAL, 6min estimated) (`internal/k8s/job_manifests.go:45`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`internal/k8s/job_manifests.go`** — Introduce a package-level constant for the restic cache directory and use it at the three sites that currently repeat the literal. The constant's value is identical to the current literal, so the generated manifests are byte-for-byte unchanged. (The "/cache/restore" paths inside restoreCommand are a different literal and are intentionally left as-is to keep the shell command string identical.) ``` // Add near the top of the file, after the imports: const resticCacheDir = "/cache" // In buildBackupJob, replace the container VolumeMounts with: VolumeMounts: []corev1.VolumeMount{ {Name: "data", MountPath: "/data", ReadOnly: true}, {Name: "cache", MountPath: resticCacheDir}, }, // In buildRestoreJob, replace the container VolumeMounts with: VolumeMounts: []corev1.VolumeMount{ {Name: "restore", MountPath: "/restore"}, {Name: "cache", MountPath: resticCacheDir}, }, // In resticEnv, replace the RESTIC_CACHE_DIR entry with: {Name: "RESTIC_CACHE_DIR", Value: resticCacheDir}, ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=soteria&open=AZ9pTqVcN0JrBQvDGDs3 - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_d2898bceac7e441599e92e792edca69c](https://triage.bstein.dev/chat?resume=run_d2898bceac7e441599e92e792edca69c)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: titan/soteria#66