[hermes] soteria: go:S1192 #51

New Issue

hermes-automation · 2026-09-26T20:35:04Z

hermes-automation commented

2026-09-26 20:35:04 +00:00

SonarQube reports go:S1192 in internal/k8s/job_manifests.go. The build is green; this is a standing finding, not a failure.

What is wrong

The string literal "/cache" is duplicated three times in internal/k8s/job_manifests.go: as the cache volume MountPath in buildBackupJob, as the cache volume MountPath in buildRestoreJob, and as the RESTIC_CACHE_DIR value in resticEnv. If the cache path ever changed, these three sites could silently drift apart, which is exactly what go:S1192 flags.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Define a constant instead of duplicating this literal "/cache" 3 times. (CRITICAL, 6min estimated) (internal/k8s/job_manifests.go:45)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

internal/k8s/job_manifests.go — Introduce a single package-level constant for the restic cache mount path and use it at all three sites. The constant value is identical to the current literal, so the generated manifests and environment are byte-for-byte unchanged. Add the constant near the top of the file (after the imports), then replace the three occurrences: the VolumeMount in buildBackupJob, the VolumeMount in buildRestoreJob, and the RESTIC_CACHE_DIR EnvVar in resticEnv. The "/cache/restore" paths inside restoreCommand are a different literal and are not part of this finding, so they are left as-is to keep the shell com
... (truncated)

// After the import block:
const cacheMountPath = "/cache"

// In buildBackupJob:
VolumeMounts: []corev1.VolumeMount{
	{Name: "data", MountPath: "/data", ReadOnly: true},
	{Name: "cache", MountPath: cacheMountPath},
},

// In buildRestoreJob:
VolumeMounts: []corev1.VolumeMount{
	{Name: "restore", MountPath: "/restore"},
	{Name: "cache", MountPath: cacheMountPath},
},

// In resticEnv:
{Name: "RESTIC_CACHE_DIR", Value: cacheMountPath},

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=soteria&open=AZ9pTqVcN0JrBQvDGDs3
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_2297943560e543dc8d1e5a43f7c5b8a2). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **go:S1192** in `internal/k8s/job_manifests.go`. The build is green; this is a standing finding, not a failure. ## What is wrong The string literal "/cache" is duplicated three times in internal/k8s/job_manifests.go: as the cache volume MountPath in buildBackupJob, as the cache volume MountPath in buildRestoreJob, and as the RESTIC_CACHE_DIR value in resticEnv. If the cache path ever changed, these three sites could silently drift apart, which is exactly what go:S1192 flags. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Define a constant instead of duplicating this literal "/cache" 3 times. (CRITICAL, 6min estimated) (`internal/k8s/job_manifests.go:45`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`internal/k8s/job_manifests.go`** — Introduce a single package-level constant for the restic cache mount path and use it at all three sites. The constant value is identical to the current literal, so the generated manifests and environment are byte-for-byte unchanged. Add the constant near the top of the file (after the imports), then replace the three occurrences: the VolumeMount in buildBackupJob, the VolumeMount in buildRestoreJob, and the RESTIC_CACHE_DIR EnvVar in resticEnv. The "/cache/restore" paths inside restoreCommand are a different literal and are not part of this finding, so they are left as-is to keep the shell com ... (truncated) ``` // After the import block: const cacheMountPath = "/cache" // In buildBackupJob: VolumeMounts: []corev1.VolumeMount{ {Name: "data", MountPath: "/data", ReadOnly: true}, {Name: "cache", MountPath: cacheMountPath}, }, // In buildRestoreJob: VolumeMounts: []corev1.VolumeMount{ {Name: "restore", MountPath: "/restore"}, {Name: "cache", MountPath: cacheMountPath}, }, // In resticEnv: {Name: "RESTIC_CACHE_DIR", Value: cacheMountPath}, ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=soteria&open=AZ9pTqVcN0JrBQvDGDs3 - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_2297943560e543dc8d1e5a43f7c5b8a2](https://triage.bstein.dev/chat?resume=run_2297943560e543dc8d1e5a43f7c5b8a2)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: titan/soteria#51