[hermes] soteria: go:S1192 #38

New Issue

hermes-automation · 2026-09-23T05:32:48Z

hermes-automation commented

2026-09-23 05:32:48 +00:00

SonarQube reports go:S1192 in internal/k8s/job_manifests.go. The build is green; this is a standing finding, not a failure.

What is wrong

The literal "/cache" is duplicated in the backup and restore volume mounts and the RESTIC_CACHE_DIR environment variable. A shared package-level constant removes this duplication without changing any generated values or runtime behavior.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Define a constant instead of duplicating this literal "/cache" 3 times. (CRITICAL, 6min estimated) (internal/k8s/job_manifests.go:45)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

internal/k8s/job_manifests.go — Add resticCacheDir after the import block and replace the three standalone "/cache" literals with it, as shown below. Leave restoreCommand unchanged: its longer shell-command string is not one of the three duplicated literals. All paths remain exactly the same.

// Add at package scope after the import block:
const resticCacheDir = "/cache"

// In buildBackupJob, replace the cache VolumeMount entry with:
{Name: "cache", MountPath: resticCacheDir},

// In buildRestoreJob, replace the cache VolumeMount entry with:
{Name: "cache", MountPath: resticCacheDir},

// In resticEnv, replace the RESTIC_CACHE_DIR entry with:
{Name: "RESTIC_CACHE_DIR", Value: resticCacheDir},

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=soteria&open=AZ9pTqVcN0JrBQvDGDs3
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_a39509e7ea124848a9c7f56196139601). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **go:S1192** in `internal/k8s/job_manifests.go`. The build is green; this is a standing finding, not a failure. ## What is wrong The literal "/cache" is duplicated in the backup and restore volume mounts and the RESTIC_CACHE_DIR environment variable. A shared package-level constant removes this duplication without changing any generated values or runtime behavior. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Define a constant instead of duplicating this literal "/cache" 3 times. (CRITICAL, 6min estimated) (`internal/k8s/job_manifests.go:45`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`internal/k8s/job_manifests.go`** — Add resticCacheDir after the import block and replace the three standalone "/cache" literals with it, as shown below. Leave restoreCommand unchanged: its longer shell-command string is not one of the three duplicated literals. All paths remain exactly the same. ``` // Add at package scope after the import block: const resticCacheDir = "/cache" // In buildBackupJob, replace the cache VolumeMount entry with: {Name: "cache", MountPath: resticCacheDir}, // In buildRestoreJob, replace the cache VolumeMount entry with: {Name: "cache", MountPath: resticCacheDir}, // In resticEnv, replace the RESTIC_CACHE_DIR entry with: {Name: "RESTIC_CACHE_DIR", Value: resticCacheDir}, ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=soteria&open=AZ9pTqVcN0JrBQvDGDs3 - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_a39509e7ea124848a9c7f56196139601](https://triage.bstein.dev/chat?resume=run_a39509e7ea124848a9c7f56196139601)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: titan/soteria#38