From d788f33013370d1c1469804ef77ec08516c5cd94 Mon Sep 17 00:00:00 2001 From: Hermes Agent Date: Mon, 2 Nov 2026 16:34:02 +0000 Subject: [PATCH] fix(hermes): The metric remains 1 for healthy PVCs and 0 otherwise. Removing the else branch lowers Sonar cognitive complexity by one without changing behavior. (incident sonar/soteria/go:S3776/AZ4WREVmqCRMjDT4bXbu) --- internal/server/metrics.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/server/metrics.go b/internal/server/metrics.go index 5893b8e..8674f9f 100644 --- a/internal/server/metrics.go +++ b/internal/server/metrics.go @@ -162,11 +162,11 @@ func (t *telemetry) RecordInventory(inv api.InventoryResponse) { } reasonLabels["reason"] = reason setMetric(t.pvcBackupHealthReason, reasonLabels, 1) + health := 0.0 if pvc.Healthy { - setMetric(t.pvcBackupHealth, labels, 1) - } else { - setMetric(t.pvcBackupHealth, labels, 0) + health = 1 } + setMetric(t.pvcBackupHealth, labels, health) if pvc.LastBackupAt == "" { continue }