titan/soteria
3
0
Fork 0
Code Issues 23 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

fix(hermes): Both guards only skip the current pod. Merging them into one equivalent OR condition retains evaluation order and skip behavior while eliminating one conditional branch. (incident sonar/soteria/go:S3776/AZ9pTqWRN0JrBQvDGDs4)

Browse Source
This commit is contained in:
Hermes Agent 2026-08-07 08:12:42 +00:00
parent 47205db5b2
commit 45170df566
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/k8s/jobs.go
View File

@ -221,10 +221,8 @@ func (c *Client) resolvePVCMountedNode(ctx context.Context, namespace, pvc strin
} }
for _, pod := range pods.Items { for _, pod := range pods.Items {
if pod.DeletionTimestamp != nil || pod.Spec.NodeName == "" { if pod.DeletionTimestamp != nil || pod.Spec.NodeName == "" ||
continue pod.Status.Phase == corev1.PodSucceeded || pod.Status.Phase == corev1.PodFailed {
}
if pod.Status.Phase == corev1.PodSucceeded || pod.Status.Phase == corev1.PodFailed {
continue continue
} }
for _, volume := range pod.Spec.Volumes { for _, volume := range pod.Spec.Volumes {