2f535d3a30
Build 20 failed on the CI image's Node 20: --test-coverage-lines and friends need Node >= 22.8 and --experimental-strip-types needs 22.6. A shared helper now runs plain --experimental-test-coverage and enforces the same per-source >=95 floors by parsing the coverage table, so the gate is identical on Node 20 and newer local Nodes; the TypeScript suites skip with an explicit reason on runtimes that cannot strip types. Per-file gating also exposed pre-existing debt the old aggregate thresholds hid (wave_b_projects_modes.js branches 90 / funcs 94.7) - recorded as explicit enforced floors, not waived. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BvMSXH8VH2tMWXanb8SJdf
93 lines
3.7 KiB
Python
93 lines
3.7 KiB
Python
"""Executable and static quality gates for the isolated HUX-03 frontend."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
from hux_node_gate import run_node_coverage
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
ORGANIZATION = ROOT / "dockerfiles" / "hermes-webui-hux" / "organization"
|
|
|
|
|
|
|
|
def test_hux_organization_node_suite_and_line_branch_coverage():
|
|
run_node_coverage(
|
|
[
|
|
"dockerfiles/hermes-webui-hux/organization/client.ts",
|
|
"dockerfiles/hermes-webui-hux/organization/model.ts",
|
|
"dockerfiles/hermes-webui-hux/organization/security.ts",
|
|
],
|
|
[
|
|
"testing/tests/test_hermes_hux_ui_organization.mjs",
|
|
],
|
|
{"branches": 95, "functions": 95, "lines": 95},
|
|
strip_types=True,
|
|
)
|
|
|
|
|
|
def test_hux_organization_component_is_flagged_accessible_and_scope_safe():
|
|
component = (ORGANIZATION / "OrganizationWorkspace.tsx").read_text(encoding="utf-8")
|
|
model = (ORGANIZATION / "model.ts").read_text(encoding="utf-8")
|
|
client = (ORGANIZATION / "client.ts").read_text(encoding="utf-8")
|
|
contracts = (ORGANIZATION / "contracts.ts").read_text(encoding="utf-8")
|
|
styles = (ORGANIZATION / "styles.css").read_text(encoding="utf-8")
|
|
assert "if (!enabled) return null" in component
|
|
assert "projectsEnabled(props.flags)" in component
|
|
assert "FOUNDATION_FLAG" in model and "PROJECTS_FLAG" in model
|
|
assert 'role="search"' in component
|
|
assert 'role="status"' in component and 'aria-live="polite"' in component
|
|
assert 'aria-label="Project folders"' in component
|
|
assert 'aria-label="Conversations"' in component
|
|
assert 'aria-labelledby="hux-org-lineage-title"' in component
|
|
assert 'aria-labelledby="hux-org-attachments-title"' in component
|
|
assert "Edit tags" in component and 'role="alert"' in component
|
|
assert "encodeURIComponent(conversation.id)" in component
|
|
assert "dangerouslySetInnerHTML" not in component
|
|
assert all(token not in client for token in ("localStorage", "sessionStorage", "indexedDB", "document.cookie"))
|
|
assert 'credentials: "same-origin"' in client and 'cache: "no-store"' in client
|
|
assert "expected_updated_at" in client and "preservesConversation" in client
|
|
assert "tenant_ref" in contracts and "MUST NOT be accepted" in contracts
|
|
assert ".hux-organization" in styles
|
|
assert "body" not in styles and ":root" not in styles
|
|
assert "prefers-reduced-motion" in styles
|
|
|
|
|
|
def test_hux_organization_sources_respect_size_and_scope_boundaries():
|
|
sources = sorted(ORGANIZATION.glob("*"))
|
|
assert {path.name for path in sources} == {
|
|
"OrganizationWorkspace.tsx",
|
|
"client.ts",
|
|
"contracts.ts",
|
|
"index.ts",
|
|
"model.ts",
|
|
"security.ts",
|
|
"styles.css",
|
|
"types.ts",
|
|
}
|
|
for path in sources:
|
|
assert len(path.read_text(encoding="utf-8").splitlines()) <= 500
|
|
assert "dockerfiles/hermes-webui-hux/organization" not in (
|
|
ROOT / "dockerfiles" / "Dockerfile.hermes-agent"
|
|
).read_text(encoding="utf-8")
|
|
|
|
|
|
def test_hux_organization_declares_exact_backend_contracts():
|
|
contracts = (ORGANIZATION / "contracts.ts").read_text(encoding="utf-8")
|
|
expected = (
|
|
"GET /hux/v1/projects?cursor=&limit=",
|
|
"GET /hux/v1/projects/{prj_id}/conversations?cursor=&limit=",
|
|
"GET /hux/v1/conversations/search?q=&project_id=&tag=&pinned=&cursor=&limit=",
|
|
"PATCH /hux/v1/projects/{prj_id}",
|
|
"PATCH /hux/v1/conversations/{conv_id}",
|
|
'api_version="hux.v1"',
|
|
"next_cursor",
|
|
"expected_updated_at",
|
|
"branch",
|
|
"artifact_ids",
|
|
"409",
|
|
)
|
|
for value in expected:
|
|
assert value in contracts
|