[hermes] ariadne: python:S2208 #136

New Issue

hermes-automation · 2026-09-30T10:19:16Z

hermes-automation commented

2026-09-30 10:19:16 +00:00

SonarQube reports python:S2208 in ariadne/services/cluster_state_profiles.py. The build is green; this is a standing finding, not a failure.

What is wrong

The module uses a wildcard import (from .cluster_state_contract import *) to pull in the names it needs (ClusterStateSummary, SignalContext, _NODE_WORKLOAD_TOP, _PROFILE_LIMIT), which hides where those names actually come from and risks silently shadowing other module-level names.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Import only needed names or import the module and then use its members. (CRITICAL, 5min estimated) (ariadne/services/cluster_state_profiles.py:5)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

ariadne/services/cluster_state_profiles.py — Replace the wildcard import with an explicit import list of the exact names this module consumes (ClusterStateSummary, SignalContext used via all, and _NODE_WORKLOAD_TOP/_PROFILE_LIMIT used in the profile-building functions). This satisfies S2208 while binding the identical names with identical values, so behavior is unchanged.

from .cluster_state_contract import (
    ClusterStateSummary,
    SignalContext,
    _NODE_WORKLOAD_TOP,
    _PROFILE_LIMIT,
)

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=ariadne&open=AZ2y0FYFKy9i4pkIpNlV
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_9fb8f3e90ac64206b4c0607dbd238aa7). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S2208** in `ariadne/services/cluster_state_profiles.py`. The build is green; this is a standing finding, not a failure. ## What is wrong The module uses a wildcard import (`from .cluster_state_contract import *`) to pull in the names it needs (`ClusterStateSummary`, `SignalContext`, `_NODE_WORKLOAD_TOP`, `_PROFILE_LIMIT`), which hides where those names actually come from and risks silently shadowing other module-level names. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Import only needed names or import the module and then use its members. (CRITICAL, 5min estimated) (`ariadne/services/cluster_state_profiles.py:5`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`ariadne/services/cluster_state_profiles.py`** — Replace the wildcard import with an explicit import list of the exact names this module consumes (`ClusterStateSummary`, `SignalContext` used via __all__, and `_NODE_WORKLOAD_TOP`/`_PROFILE_LIMIT` used in the profile-building functions). This satisfies S2208 while binding the identical names with identical values, so behavior is unchanged. ``` from .cluster_state_contract import ( ClusterStateSummary, SignalContext, _NODE_WORKLOAD_TOP, _PROFILE_LIMIT, ) ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=ariadne&open=AZ2y0FYFKy9i4pkIpNlV - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_9fb8f3e90ac64206b4c0607dbd238aa7](https://triage.bstein.dev/chat?resume=run_9fb8f3e90ac64206b4c0607dbd238aa7)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: titan/ariadne#136