[hermes] ariadne: python:S2208 #132

New Issue

hermes-automation · 2026-09-29T02:19:25Z

hermes-automation commented

2026-09-29 02:19:25 +00:00

SonarQube reports python:S2208 in ariadne/services/cluster_state_profiles.py. The build is green; this is a standing finding, not a failure.

What is wrong

Line 5 uses a wildcard import (from .cluster_state_contract import *), which hides where names come from and pulls in everything the contract module exports. This module actually needs only four of those names: _NODE_WORKLOAD_TOP and _PROFILE_LIMIT (used in the profile-building functions) plus ClusterStateSummary and SignalContext (re-exported via the dynamic __all__ at the bottom of the file).

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Import only needed names or import the module and then use its members. (CRITICAL, 5min estimated) (ariadne/services/cluster_state_profiles.py:5)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

ariadne/services/cluster_state_profiles.py — Replace the wildcard import on line 5 with an explicit import of the names this module references. _NODE_WORKLOAD_TOP and _PROFILE_LIMIT are the only contract names used directly in the code, and ClusterStateSummary and SignalContext must also be imported explicitly because the __all__ comprehension at the end of the file only re-exports names that are present in globals() — importing them keeps that re-export behaviour identical. No other line changes; the dynamic __all__ still picks up the same set of names.

from .cluster_state_contract import (
    _NODE_WORKLOAD_TOP,
    _PROFILE_LIMIT,
    ClusterStateSummary,
    SignalContext,
)

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=ariadne&open=AZ2y0FYFKy9i4pkIpNlV
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_dee17b6ceac946f5a971d589e7549c78). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S2208** in `ariadne/services/cluster_state_profiles.py`. The build is green; this is a standing finding, not a failure. ## What is wrong Line 5 uses a wildcard import (`from .cluster_state_contract import *`), which hides where names come from and pulls in everything the contract module exports. This module actually needs only four of those names: `_NODE_WORKLOAD_TOP` and `_PROFILE_LIMIT` (used in the profile-building functions) plus `ClusterStateSummary` and `SignalContext` (re-exported via the dynamic `__all__` at the bottom of the file). Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Import only needed names or import the module and then use its members. (CRITICAL, 5min estimated) (`ariadne/services/cluster_state_profiles.py:5`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`ariadne/services/cluster_state_profiles.py`** — Replace the wildcard import on line 5 with an explicit import of the names this module references. `_NODE_WORKLOAD_TOP` and `_PROFILE_LIMIT` are the only contract names used directly in the code, and `ClusterStateSummary` and `SignalContext` must also be imported explicitly because the `__all__` comprehension at the end of the file only re-exports names that are present in `globals()` — importing them keeps that re-export behaviour identical. No other line changes; the dynamic `__all__` still picks up the same set of names. ``` from .cluster_state_contract import ( _NODE_WORKLOAD_TOP, _PROFILE_LIMIT, ClusterStateSummary, SignalContext, ) ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=ariadne&open=AZ2y0FYFKy9i4pkIpNlV - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_dee17b6ceac946f5a971d589e7549c78](https://triage.bstein.dev/chat?resume=run_dee17b6ceac946f5a971d589e7549c78)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: titan/ariadne#132