[hermes] ariadne: python:S2208 #131

New Issue

hermes-automation · 2026-09-28T23:20:04Z

hermes-automation commented

2026-09-28 23:20:04 +00:00

SonarQube reports python:S2208 in ariadne/services/cluster_state_profiles.py. The build is green; this is a standing finding, not a failure.

What is wrong

Line 5 uses a wildcard import (from .cluster_state_contract import *), which hides the module's real dependencies. The file only relies on four names from that module: _NODE_WORKLOAD_TOP and _PROFILE_LIMIT (used in the profile builders) plus ClusterStateSummary and SignalContext (re-exported via the dynamic all at the bottom).

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Import only needed names or import the module and then use its members. (CRITICAL, 5min estimated) (ariadne/services/cluster_state_profiles.py:5)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

ariadne/services/cluster_state_profiles.py — Replace the star import on line 5 with an explicit import of the four names this module actually uses. Since the underscore-prefixed constants are picked up by the star import, they must already be listed in cluster_state_contract's all, so importing them by name is valid and behaviour-preserving: they still land in globals(), which keeps both the functions and the dynamically computed all working exactly as before.

from .cluster_state_contract import (
    ClusterStateSummary,
    SignalContext,
    _NODE_WORKLOAD_TOP,
    _PROFILE_LIMIT,
)

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=ariadne&open=AZ2y0FYFKy9i4pkIpNlV
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_6aa7f0b215904ece995e613c94f0d680). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S2208** in `ariadne/services/cluster_state_profiles.py`. The build is green; this is a standing finding, not a failure. ## What is wrong Line 5 uses a wildcard import (from .cluster_state_contract import *), which hides the module's real dependencies. The file only relies on four names from that module: _NODE_WORKLOAD_TOP and _PROFILE_LIMIT (used in the profile builders) plus ClusterStateSummary and SignalContext (re-exported via the dynamic __all__ at the bottom). Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Import only needed names or import the module and then use its members. (CRITICAL, 5min estimated) (`ariadne/services/cluster_state_profiles.py:5`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`ariadne/services/cluster_state_profiles.py`** — Replace the star import on line 5 with an explicit import of the four names this module actually uses. Since the underscore-prefixed constants are picked up by the star import, they must already be listed in cluster_state_contract's __all__, so importing them by name is valid and behaviour-preserving: they still land in globals(), which keeps both the functions and the dynamically computed __all__ working exactly as before. ``` from .cluster_state_contract import ( ClusterStateSummary, SignalContext, _NODE_WORKLOAD_TOP, _PROFILE_LIMIT, ) ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=ariadne&open=AZ2y0FYFKy9i4pkIpNlV - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_6aa7f0b215904ece995e613c94f0d680](https://triage.bstein.dev/chat?resume=run_6aa7f0b215904ece995e613c94f0d680)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: titan/ariadne#131