services/communication/mas-admin-client-secret-ensure-job.yaml

@@ -33,14 +33,14 @@ subjects:
 apiVersion: batch/v1
 kind: Job
 metadata:
-  name: mas-admin-client-secret-ensure-4
+  name: mas-admin-client-secret-ensure-5
   namespace: comms
 spec:
-  backoffLimit: 2
+  backoffLimit: 0
   template:
     spec:
       serviceAccountName: mas-admin-client-secret-writer
-      restartPolicy: OnFailure
+      restartPolicy: Never
       volumes:
         - name: work
           emptyDir: {}
@@ -50,7 +50,7 @@ spec:
           command: ["/bin/sh", "-c"]
           args:
             - |
-              set -eu
+              set -euo pipefail
               umask 077
               dd if=/dev/urandom bs=32 count=1 2>/dev/null | od -An -tx1 | tr -d ' \n' > /work/client_secret
           volumeMounts:
@@ -62,12 +62,12 @@ spec:
           command: ["/bin/sh", "-c"]
           args:
             - |
-              set -eu
-              if [ -n "$(kubectl -n comms get secret mas-admin-client -o jsonpath='{.data.client_secret}' 2>/dev/null || true)" ]; then
+              set -euo pipefail
+              if kubectl -n comms get secret mas-admin-client -o jsonpath='{.data.client_secret}' 2>/dev/null | grep -q .; then
                 exit 0
               fi
-              secret="$(cat /work/client_secret)"
-              payload="$(printf '{"stringData":{"client_secret":"%s"}}' "${secret}")"
+              secret_b64="$(base64 /work/client_secret | tr -d '\n')"
+              payload="$(printf '{"data":{"client_secret":"%s"}}' "${secret_b64}")"
               kubectl -n comms patch secret mas-admin-client --type=merge -p "${payload}" >/dev/null
           volumeMounts:
             - name: work