From a07b49a05ff94d510bebb12d9c66a03b012ee958 Mon Sep 17 00:00:00 2001
From: jenkins <jenkins@bstein.dev>
Date: Mon, 20 Apr 2026 12:20:42 -0300
Subject: [PATCH] monitoring(testing): fix atlas-jobs coverage and loc query
 expressions

---
 scripts/dashboards_render_atlas.py              | 10 ++--------
 services/monitoring/dashboards/atlas-jobs.json  |  4 ++--
 services/monitoring/grafana-dashboard-jobs.yaml |  4 ++--
 3 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/scripts/dashboards_render_atlas.py b/scripts/dashboards_render_atlas.py
index 710aee68..451275a4 100644
--- a/scripts/dashboards_render_atlas.py
+++ b/scripts/dashboards_render_atlas.py
@@ -3015,16 +3015,10 @@ def build_jobs_dashboard():
         f'(max by (suite) ({{{coverage_metric_selector}}})) '
         f'or on(suite) (max by (suite) (platform_quality_gate_workspace_line_coverage_percent{{{workspace_coverage_selector}}}))'
     )
-    coverage_with_missing = (
-        f"({coverage_by_suite}) or on(suite) (0 * (sum by (suite) (increase(platform_quality_gate_runs_total{{{runs_selector}}}[30d]))) - 1)"
-        ")"
-    )
+    coverage_with_missing = coverage_by_suite
     coverage_gap = f"clamp_min(95 - ({coverage_by_suite}), 0)"
     smell_by_suite = f'max by (suite) (platform_quality_gate_source_lines_over_500_total{{{smell_selector}}})'
-    smell_with_missing = (
-        f"({smell_by_suite}) or on(suite) (0 * (sum by (suite) (increase(platform_quality_gate_runs_total{{{runs_selector}}}[30d]))) - 1)"
-        ")"
-    )
+    smell_with_missing = smell_by_suite
     average_coverage = f"(avg(({coverage_by_suite})) or on() vector(0))"
     suites_loc_violating = f'(sum((({smell_by_suite}) > bool 0)) or on() vector(0))'
 
diff --git a/services/monitoring/dashboards/atlas-jobs.json b/services/monitoring/dashboards/atlas-jobs.json
index 4f96283c..73c2a691 100644
--- a/services/monitoring/dashboards/atlas-jobs.json
+++ b/services/monitoring/dashboards/atlas-jobs.json
@@ -2233,7 +2233,7 @@
       },
       "targets": [
         {
-          "expr": "sort(((max by (suite) ({__name__=~\".*_quality_gate_coverage_percent\",suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"})) or on(suite) (max by (suite) (platform_quality_gate_workspace_line_coverage_percent{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"}))) or on(suite) (0 * (sum by (suite) (increase(platform_quality_gate_runs_total{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"}[30d]))) - 1)))",
+          "expr": "sort((max by (suite) ({__name__=~\".*_quality_gate_coverage_percent\",suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"})) or on(suite) (max by (suite) (platform_quality_gate_workspace_line_coverage_percent{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"})))",
           "refId": "A",
           "legendFormat": "{{suite}}",
           "instant": true
@@ -2318,7 +2318,7 @@
       },
       "targets": [
         {
-          "expr": "sort_desc((max by (suite) (platform_quality_gate_source_lines_over_500_total{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"})) or on(suite) (0 * (sum by (suite) (increase(platform_quality_gate_runs_total{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"}[30d]))) - 1)))",
+          "expr": "sort_desc(max by (suite) (platform_quality_gate_source_lines_over_500_total{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"}))",
           "refId": "A",
           "legendFormat": "{{suite}}",
           "instant": true
diff --git a/services/monitoring/grafana-dashboard-jobs.yaml b/services/monitoring/grafana-dashboard-jobs.yaml
index 2ed3d7c6..686baf8e 100644
--- a/services/monitoring/grafana-dashboard-jobs.yaml
+++ b/services/monitoring/grafana-dashboard-jobs.yaml
@@ -2242,7 +2242,7 @@ data:
           },
           "targets": [
             {
-              "expr": "sort(((max by (suite) ({__name__=~\".*_quality_gate_coverage_percent\",suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"})) or on(suite) (max by (suite) (platform_quality_gate_workspace_line_coverage_percent{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"}))) or on(suite) (0 * (sum by (suite) (increase(platform_quality_gate_runs_total{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"}[30d]))) - 1)))",
+              "expr": "sort((max by (suite) ({__name__=~\".*_quality_gate_coverage_percent\",suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"})) or on(suite) (max by (suite) (platform_quality_gate_workspace_line_coverage_percent{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"})))",
               "refId": "A",
               "legendFormat": "{{suite}}",
               "instant": true
@@ -2327,7 +2327,7 @@ data:
           },
           "targets": [
             {
-              "expr": "sort_desc((max by (suite) (platform_quality_gate_source_lines_over_500_total{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"})) or on(suite) (0 * (sum by (suite) (increase(platform_quality_gate_runs_total{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"}[30d]))) - 1)))",
+              "expr": "sort_desc(max by (suite) (platform_quality_gate_source_lines_over_500_total{suite=~\"${suite:regex}\",exported_job=\"platform-quality-ci\"}))",
               "refId": "A",
               "legendFormat": "{{suite}}",
               "instant": true