From 53423c7a46f8d3a405aeef33c991968be9db8cbb Mon Sep 17 00:00:00 2001 From: Brad Stein Date: Sat, 13 Dec 2025 04:00:57 -0300 Subject: [PATCH] atlas pods: fix namespace plurality query --- scripts/dashboards_render_atlas.py | 8 +++++--- services/monitoring/dashboards/atlas-pods.json | 5 +++-- services/monitoring/grafana-dashboard-pods.yaml | 5 +++-- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/scripts/dashboards_render_atlas.py b/scripts/dashboards_render_atlas.py index 181fb38..6fa737e 100644 --- a/scripts/dashboards_render_atlas.py +++ b/scripts/dashboards_render_atlas.py @@ -519,6 +519,7 @@ def table_panel( *, unit="none", transformations=None, + instant=False, ): """Return a Grafana table panel definition.""" panel = { @@ -527,7 +528,7 @@ def table_panel( "title": title, "datasource": PROM_DS, "gridPos": grid, - "targets": [{"expr": expr, "refId": "A"}], + "targets": [{"expr": expr, "refId": "A", **({"instant": True} if instant else {})}], "fieldConfig": {"defaults": {"unit": unit}, "overrides": []}, "options": {"showHeader": True}, } @@ -1175,14 +1176,15 @@ def build_pods_dashboard(): table_panel( 10, "Namespace Plurality by Node", - 'topk(1, sum by (namespace,node) (kube_pod_info{pod!=""}) ' - '/ ignoring(node) sum by (namespace) (kube_pod_info{pod!=""}))', + 'sort_desc(topk(100, sum by (namespace,node) (kube_pod_info{pod!=""}) ' + '/ on(namespace) group_left sum by (namespace) (kube_pod_info{pod!=""})))', {"h": 8, "w": 24, "x": 0, "y": 42}, unit="percent", transformations=[ {"id": "labelsToFields", "options": {}}, {"id": "sortBy", "options": {"fields": ["Value"], "order": "desc"}}, ], + instant=True, ) ) return { diff --git a/services/monitoring/dashboards/atlas-pods.json b/services/monitoring/dashboards/atlas-pods.json index 3bb2c47..4070c81 100644 --- a/services/monitoring/dashboards/atlas-pods.json +++ b/services/monitoring/dashboards/atlas-pods.json @@ -508,8 +508,9 @@ }, "targets": [ { - "expr": "topk(1, sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / ignoring(node) sum by (namespace) (kube_pod_info{pod!=\"\"}))", - "refId": "A" + "expr": "sort_desc(topk(100, sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / on(namespace) group_left sum by (namespace) (kube_pod_info{pod!=\"\"})))", + "refId": "A", + "instant": true } ], "fieldConfig": { diff --git a/services/monitoring/grafana-dashboard-pods.yaml b/services/monitoring/grafana-dashboard-pods.yaml index ddffec2..275cb78 100644 --- a/services/monitoring/grafana-dashboard-pods.yaml +++ b/services/monitoring/grafana-dashboard-pods.yaml @@ -517,8 +517,9 @@ data: }, "targets": [ { - "expr": "topk(1, sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / ignoring(node) sum by (namespace) (kube_pod_info{pod!=\"\"}))", - "refId": "A" + "expr": "sort_desc(topk(100, sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / on(namespace) group_left sum by (namespace) (kube_pod_info{pod!=\"\"})))", + "refId": "A", + "instant": true } ], "fieldConfig": {