From 5277c98385bb6d1d5331ffae436de11f82623544 Mon Sep 17 00:00:00 2001 From: Brad Stein Date: Fri, 12 Dec 2025 20:40:32 -0300 Subject: [PATCH] atlas dashboards: fix pod share display and zero/red stat thresholds --- scripts/dashboards_render_atlas.py | 14 ++++----- services/monitoring/dashboards/atlas-gpu.json | 5 +--- .../monitoring/dashboards/atlas-overview.json | 30 ++++++------------- .../monitoring/dashboards/atlas-pods.json | 7 ++--- .../monitoring/grafana-dashboard-gpu.yaml | 5 +--- .../grafana-dashboard-overview.yaml | 30 ++++++------------- .../monitoring/grafana-dashboard-pods.yaml | 7 ++--- 7 files changed, 31 insertions(+), 67 deletions(-) diff --git a/scripts/dashboards_render_atlas.py b/scripts/dashboards_render_atlas.py index f53302b..255df8d 100644 --- a/scripts/dashboards_render_atlas.py +++ b/scripts/dashboards_render_atlas.py @@ -554,7 +554,7 @@ def pie_panel(panel_id, title, expr, grid): "options": { "legend": {"displayMode": "list", "placement": "right"}, "pieType": "pie", - "displayLabels": ["name", "percent"], + "displayLabels": [], "tooltip": {"mode": "single"}, "colorScheme": "interpolateSpectral", "colorBy": "value", @@ -686,7 +686,7 @@ def build_overview(): "thresholds": { "mode": "absolute", "steps": [ - {"color": "green", "value": None}, + {"color": "green", "value": 0}, {"color": "red", "value": 1}, ], }, @@ -700,7 +700,7 @@ def build_overview(): "thresholds": { "mode": "absolute", "steps": [ - {"color": "green", "value": None}, + {"color": "green", "value": 0}, {"color": "red", "value": 1}, ], }, @@ -724,7 +724,7 @@ def build_overview(): "thresholds": { "mode": "absolute", "steps": [ - {"color": "green", "value": None}, + {"color": "green", "value": 0}, {"color": "red", "value": 1}, ], }, @@ -738,7 +738,7 @@ def build_overview(): "thresholds": { "mode": "absolute", "steps": [ - {"color": "green", "value": None}, + {"color": "green", "value": 0}, {"color": "red", "value": 1}, ], }, @@ -927,7 +927,7 @@ def build_overview(): pie_panel( 28, "Node Pod Share", - 'sum(kube_pod_info{pod!="" , node!=""}) by (node)', + '(sum(kube_pod_info{pod!="" , node!=""}) by (node) / clamp_min(sum(kube_pod_info{pod!="" , node!=""}), 1)) * 100', {"h": 10, "w": 12, "x": 0, "y": 54}, ) ) @@ -1136,7 +1136,7 @@ def build_pods_dashboard(): pie_panel( 8, "Node Pod Share", - 'sum(kube_pod_info{pod!="" , node!=""}) by (node)', + '(sum(kube_pod_info{pod!="" , node!=""}) by (node) / clamp_min(sum(kube_pod_info{pod!="" , node!=""}), 1)) * 100', {"h": 8, "w": 12, "x": 12, "y": 34}, ) ) diff --git a/services/monitoring/dashboards/atlas-gpu.json b/services/monitoring/dashboards/atlas-gpu.json index 558aa63..3d7a629 100644 --- a/services/monitoring/dashboards/atlas-gpu.json +++ b/services/monitoring/dashboards/atlas-gpu.json @@ -40,10 +40,7 @@ "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, diff --git a/services/monitoring/dashboards/atlas-overview.json b/services/monitoring/dashboards/atlas-overview.json index d269e6d..10c901a 100644 --- a/services/monitoring/dashboards/atlas-overview.json +++ b/services/monitoring/dashboards/atlas-overview.json @@ -91,7 +91,7 @@ "steps": [ { "color": "green", - "value": null + "value": 0 }, { "color": "red", @@ -158,7 +158,7 @@ "steps": [ { "color": "green", - "value": null + "value": 0 }, { "color": "red", @@ -294,7 +294,7 @@ "steps": [ { "color": "green", - "value": null + "value": 0 }, { "color": "red", @@ -361,7 +361,7 @@ "steps": [ { "color": "green", - "value": null + "value": 0 }, { "color": "red", @@ -1054,10 +1054,7 @@ "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, @@ -1108,10 +1105,7 @@ "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, @@ -1162,10 +1156,7 @@ "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, @@ -1364,7 +1355,7 @@ }, "targets": [ { - "expr": "sum(kube_pod_info{pod!=\"\" , node!=\"\"}) by (node)", + "expr": "(sum(kube_pod_info{pod!=\"\" , node!=\"\"}) by (node) / clamp_min(sum(kube_pod_info{pod!=\"\" , node!=\"\"}), 1)) * 100", "refId": "A", "legendFormat": "{{namespace}}" } @@ -1384,10 +1375,7 @@ "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, diff --git a/services/monitoring/dashboards/atlas-pods.json b/services/monitoring/dashboards/atlas-pods.json index 0b139e9..6c0dcbc 100644 --- a/services/monitoring/dashboards/atlas-pods.json +++ b/services/monitoring/dashboards/atlas-pods.json @@ -376,7 +376,7 @@ }, "targets": [ { - "expr": "sum(kube_pod_info{pod!=\"\" , node!=\"\"}) by (node)", + "expr": "(sum(kube_pod_info{pod!=\"\" , node!=\"\"}) by (node) / clamp_min(sum(kube_pod_info{pod!=\"\" , node!=\"\"}), 1)) * 100", "refId": "A", "legendFormat": "{{namespace}}" } @@ -396,10 +396,7 @@ "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, diff --git a/services/monitoring/grafana-dashboard-gpu.yaml b/services/monitoring/grafana-dashboard-gpu.yaml index fee58ed..aef9ae6 100644 --- a/services/monitoring/grafana-dashboard-gpu.yaml +++ b/services/monitoring/grafana-dashboard-gpu.yaml @@ -49,10 +49,7 @@ data: "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, diff --git a/services/monitoring/grafana-dashboard-overview.yaml b/services/monitoring/grafana-dashboard-overview.yaml index 344ff5f..c7f5140 100644 --- a/services/monitoring/grafana-dashboard-overview.yaml +++ b/services/monitoring/grafana-dashboard-overview.yaml @@ -100,7 +100,7 @@ data: "steps": [ { "color": "green", - "value": null + "value": 0 }, { "color": "red", @@ -167,7 +167,7 @@ data: "steps": [ { "color": "green", - "value": null + "value": 0 }, { "color": "red", @@ -303,7 +303,7 @@ data: "steps": [ { "color": "green", - "value": null + "value": 0 }, { "color": "red", @@ -370,7 +370,7 @@ data: "steps": [ { "color": "green", - "value": null + "value": 0 }, { "color": "red", @@ -1063,10 +1063,7 @@ data: "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, @@ -1117,10 +1114,7 @@ data: "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, @@ -1171,10 +1165,7 @@ data: "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, @@ -1373,7 +1364,7 @@ data: }, "targets": [ { - "expr": "sum(kube_pod_info{pod!=\"\" , node!=\"\"}) by (node)", + "expr": "(sum(kube_pod_info{pod!=\"\" , node!=\"\"}) by (node) / clamp_min(sum(kube_pod_info{pod!=\"\" , node!=\"\"}), 1)) * 100", "refId": "A", "legendFormat": "{{namespace}}" } @@ -1393,10 +1384,7 @@ data: "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" }, diff --git a/services/monitoring/grafana-dashboard-pods.yaml b/services/monitoring/grafana-dashboard-pods.yaml index 216ef09..b34f145 100644 --- a/services/monitoring/grafana-dashboard-pods.yaml +++ b/services/monitoring/grafana-dashboard-pods.yaml @@ -385,7 +385,7 @@ data: }, "targets": [ { - "expr": "sum(kube_pod_info{pod!=\"\" , node!=\"\"}) by (node)", + "expr": "(sum(kube_pod_info{pod!=\"\" , node!=\"\"}) by (node) / clamp_min(sum(kube_pod_info{pod!=\"\" , node!=\"\"}), 1)) * 100", "refId": "A", "legendFormat": "{{namespace}}" } @@ -405,10 +405,7 @@ data: "placement": "right" }, "pieType": "pie", - "displayLabels": [ - "name", - "percent" - ], + "displayLabels": [], "tooltip": { "mode": "single" },