monitoring: clarify fresh suite signal

This commit is contained in:
jenkins 2026-05-17 00:28:07 -03:00
parent a69a21f05d
commit 2d88aab3a3
4 changed files with 9 additions and 9 deletions

View File

@ -1622,7 +1622,7 @@ OVERVIEW_PANEL_DESCRIPTIONS = {
"Flux Source": "Git branch Flux is applying; this should normally be the intended production branch.", "Flux Source": "Git branch Flux is applying; this should normally be the intended production branch.",
"Run Reliability (24h)": "Percent of published quality-gate runs that passed in 24h; higher means fresher healthy test signal.", "Run Reliability (24h)": "Percent of published quality-gate runs that passed in 24h; higher means fresher healthy test signal.",
"Failed Runs (24h)": "Published quality-gate runs that failed in 24h; zero is good, any value needs a look.", "Failed Runs (24h)": "Published quality-gate runs that failed in 24h; zero is good, any value needs a look.",
"Suites Reporting (24h)": "Suites with at least one published quality-gate run in 24h; higher means fresher dashboard signal.", "Suites With Runs (24h)": "Configured suites with at least one published quality-gate run in 24h; full count means the dashboard is fresh.",
"Avg Coverage": "Average latest line coverage across suites; higher means code is better protected by tests.", "Avg Coverage": "Average latest line coverage across suites; higher means code is better protected by tests.",
"LOC Clean Suites": "Suites with no source files over 500 LOC; full count is good for maintainability.", "LOC Clean Suites": "Suites with no source files over 500 LOC; full count is good for maintainability.",
"GitOps Health": "Flux readiness and suspension health over time; blue is perfect, warmer colors mean drift or pause.", "GitOps Health": "Flux readiness and suspension health over time; blue is perfect, warmer colors mean drift or pause.",
@ -2330,7 +2330,7 @@ def build_overview():
for panel_id, title, expr, y_pos, unit, decimals, thresholds, links in [ for panel_id, title, expr, y_pos, unit, decimals, thresholds, links in [
(151, "Run Reliability (24h)", TEST_SUCCESS_RATE_24H, 9, "percent", 1, test_success_thresholds, "atlas-testing"), (151, "Run Reliability (24h)", TEST_SUCCESS_RATE_24H, 9, "percent", 1, test_success_thresholds, "atlas-testing"),
(152, "Failed Runs (24h)", TEST_FAILURES_24H_TOTAL, 11, "none", 0, failure_count_thresholds, "atlas-testing"), (152, "Failed Runs (24h)", TEST_FAILURES_24H_TOTAL, 11, "none", 0, failure_count_thresholds, "atlas-testing"),
(153, "Suites Reporting (24h)", PLATFORM_TEST_ACTIVE_SUITES_24H, 13, "none", 0, perfect_count_thresholds, "atlas-testing"), (153, "Suites With Runs (24h)", PLATFORM_TEST_ACTIVE_SUITES_24H, 13, "none", 0, perfect_count_thresholds, "atlas-testing"),
(154, "Avg Coverage", overview_avg_coverage, 15, "percent", 1, test_success_thresholds, "atlas-testing"), (154, "Avg Coverage", overview_avg_coverage, 15, "percent", 1, test_success_thresholds, "atlas-testing"),
(155, "LOC Clean Suites", overview_loc_clean_suites, 17, "none", 0, perfect_count_thresholds, "atlas-testing"), (155, "LOC Clean Suites", overview_loc_clean_suites, 17, "none", 0, perfect_count_thresholds, "atlas-testing"),
]: ]:

View File

@ -119,12 +119,12 @@ def test_overview_uses_readable_quality_power_and_gitops_panels():
assert panels_by_title["Flux Source"]["gridPos"] == {"h": 2, "w": 3, "x": 21, "y": 7} assert panels_by_title["Flux Source"]["gridPos"] == {"h": 2, "w": 3, "x": 21, "y": 7}
assert panels_by_title["Flux Source"]["targets"][0]["legendFormat"] == "{{branch}}" assert panels_by_title["Flux Source"]["targets"][0]["legendFormat"] == "{{branch}}"
assert panels_by_title["Run Reliability (24h)"]["gridPos"] == {"h": 2, "w": 3, "x": 21, "y": 9} assert panels_by_title["Run Reliability (24h)"]["gridPos"] == {"h": 2, "w": 3, "x": 21, "y": 9}
assert panels_by_title["Suites Reporting (24h)"]["gridPos"] == {"h": 2, "w": 3, "x": 21, "y": 13} assert panels_by_title["Suites With Runs (24h)"]["gridPos"] == {"h": 2, "w": 3, "x": 21, "y": 13}
suites_reporting_expr = panels_by_title["Suites Reporting (24h)"]["targets"][0]["expr"] suites_reporting_expr = panels_by_title["Suites With Runs (24h)"]["targets"][0]["expr"]
assert "> bool 0" in suites_reporting_expr assert "> bool 0" in suites_reporting_expr
assert mod.PLATFORM_TEST_SUITE_CANONICAL_MATCHER in suites_reporting_expr assert mod.PLATFORM_TEST_SUITE_CANONICAL_MATCHER in suites_reporting_expr
assert "bstein-home" not in suites_reporting_expr assert "bstein-home" not in suites_reporting_expr
assert "published quality-gate run" in panels_by_title["Suites Reporting (24h)"]["description"] assert "published quality-gate run" in panels_by_title["Suites With Runs (24h)"]["description"]
assert panels_by_title["LOC Clean Suites"]["gridPos"] == {"h": 2, "w": 3, "x": 21, "y": 17} assert panels_by_title["LOC Clean Suites"]["gridPos"] == {"h": 2, "w": 3, "x": 21, "y": 17}
assert panels_by_title["GitOps Health"]["type"] == "state-timeline" assert panels_by_title["GitOps Health"]["type"] == "state-timeline"
assert panels_by_title["GitOps Health"]["gridPos"] == {"h": 6, "w": 6, "x": 15, "y": 7} assert panels_by_title["GitOps Health"]["gridPos"] == {"h": 6, "w": 6, "x": 15, "y": 7}

View File

@ -2282,7 +2282,7 @@
{ {
"id": 153, "id": 153,
"type": "stat", "type": "stat",
"title": "Suites Reporting (24h)", "title": "Suites With Runs (24h)",
"datasource": { "datasource": {
"type": "prometheus", "type": "prometheus",
"uid": "atlas-vm" "uid": "atlas-vm"
@ -2359,7 +2359,7 @@
"targetBlank": true "targetBlank": true
} }
], ],
"description": "Suites with at least one published quality-gate run in 24h; higher means fresher dashboard signal." "description": "Configured suites with at least one published quality-gate run in 24h; full count means the dashboard is fresh."
}, },
{ {
"id": 154, "id": 154,

View File

@ -2291,7 +2291,7 @@ data:
{ {
"id": 153, "id": 153,
"type": "stat", "type": "stat",
"title": "Suites Reporting (24h)", "title": "Suites With Runs (24h)",
"datasource": { "datasource": {
"type": "prometheus", "type": "prometheus",
"uid": "atlas-vm" "uid": "atlas-vm"
@ -2368,7 +2368,7 @@ data:
"targetBlank": true "targetBlank": true
} }
], ],
"description": "Suites with at least one published quality-gate run in 24h; higher means fresher dashboard signal." "description": "Configured suites with at least one published quality-gate run in 24h; full count means the dashboard is fresh."
}, },
{ {
"id": 154, "id": 154,