From 116606964066de7f03169455aa8ddc973c49e3a0 Mon Sep 17 00:00:00 2001
From: Brad Stein <Brad.Stein@gmail.com>
Date: Fri, 12 Dec 2025 21:13:31 -0300
Subject: [PATCH] atlas dashboards: align percent thresholds and disk bars

---
 scripts/dashboards_render_atlas.py            |  8 ++--
 .../monitoring/dashboards/atlas-overview.json | 44 +++++++++++++------
 .../monitoring/dashboards/atlas-storage.json  | 20 ++++++---
 .../grafana-dashboard-overview.yaml           | 44 +++++++++++++------
 .../monitoring/grafana-dashboard-storage.yaml | 20 ++++++---
 5 files changed, 93 insertions(+), 43 deletions(-)

diff --git a/scripts/dashboards_render_atlas.py b/scripts/dashboards_render_atlas.py
index 47f167e..5ccdd9f 100644
--- a/scripts/dashboards_render_atlas.py
+++ b/scripts/dashboards_render_atlas.py
@@ -36,11 +36,12 @@ PUBLIC_FOLDER = "overview"
 PRIVATE_FOLDER = "atlas-internal"
 
 PERCENT_THRESHOLDS = {
-    "mode": "percentage",
+    "mode": "absolute",
     "steps": [
         {"color": "green", "value": None},
-        {"color": "yellow", "value": 70},
-        {"color": "red", "value": 85},
+        {"color": "yellow", "value": 50},
+        {"color": "orange", "value": 75},
+        {"color": "red", "value": 91.5},
     ],
 }
 
@@ -1023,6 +1024,7 @@ def build_overview():
             f"topk(12, {root_usage_expr()})",
             {"h": 16, "w": 12, "x": 12, "y": 64},
             unit="percent",
+            thresholds=PERCENT_THRESHOLDS,
             links=link_to("atlas-storage"),
         )
     )
diff --git a/services/monitoring/dashboards/atlas-overview.json b/services/monitoring/dashboards/atlas-overview.json
index fe694e2..650427f 100644
--- a/services/monitoring/dashboards/atlas-overview.json
+++ b/services/monitoring/dashboards/atlas-overview.json
@@ -519,7 +519,7 @@
           },
           "mappings": [],
           "thresholds": {
-            "mode": "percentage",
+            "mode": "absolute",
             "steps": [
               {
                 "color": "green",
@@ -527,11 +527,15 @@
               },
               {
                 "color": "yellow",
-                "value": 70
+                "value": 50
+              },
+              {
+                "color": "orange",
+                "value": 75
               },
               {
                 "color": "red",
-                "value": 85
+                "value": 91.5
               }
             ]
           },
@@ -592,7 +596,7 @@
           },
           "mappings": [],
           "thresholds": {
-            "mode": "percentage",
+            "mode": "absolute",
             "steps": [
               {
                 "color": "green",
@@ -600,11 +604,15 @@
               },
               {
                 "color": "yellow",
-                "value": 70
+                "value": 50
+              },
+              {
+                "color": "orange",
+                "value": 75
               },
               {
                 "color": "red",
-                "value": 85
+                "value": 91.5
               }
             ]
           },
@@ -801,7 +809,7 @@
           },
           "mappings": [],
           "thresholds": {
-            "mode": "percentage",
+            "mode": "absolute",
             "steps": [
               {
                 "color": "green",
@@ -809,11 +817,15 @@
               },
               {
                 "color": "yellow",
-                "value": 70
+                "value": 50
+              },
+              {
+                "color": "orange",
+                "value": 75
               },
               {
                 "color": "red",
-                "value": 85
+                "value": 91.5
               }
             ]
           },
@@ -872,7 +884,7 @@
           },
           "mappings": [],
           "thresholds": {
-            "mode": "percentage",
+            "mode": "absolute",
             "steps": [
               {
                 "color": "green",
@@ -880,11 +892,15 @@
               },
               {
                 "color": "yellow",
-                "value": 70
+                "value": 50
+              },
+              {
+                "color": "orange",
+                "value": 75
               },
               {
                 "color": "red",
-                "value": 85
+                "value": 91.5
               }
             ]
           },
@@ -1722,11 +1738,11 @@
               },
               {
                 "color": "orange",
-                "value": 70
+                "value": 75
               },
               {
                 "color": "red",
-                "value": 85
+                "value": 91.5
               }
             ]
           }
diff --git a/services/monitoring/dashboards/atlas-storage.json b/services/monitoring/dashboards/atlas-storage.json
index d2a5aa2..2e548b2 100644
--- a/services/monitoring/dashboards/atlas-storage.json
+++ b/services/monitoring/dashboards/atlas-storage.json
@@ -31,7 +31,7 @@
           },
           "mappings": [],
           "thresholds": {
-            "mode": "percentage",
+            "mode": "absolute",
             "steps": [
               {
                 "color": "green",
@@ -39,11 +39,15 @@
               },
               {
                 "color": "yellow",
-                "value": 70
+                "value": 50
+              },
+              {
+                "color": "orange",
+                "value": 75
               },
               {
                 "color": "red",
-                "value": 85
+                "value": 91.5
               }
             ]
           },
@@ -95,7 +99,7 @@
           },
           "mappings": [],
           "thresholds": {
-            "mode": "percentage",
+            "mode": "absolute",
             "steps": [
               {
                 "color": "green",
@@ -103,11 +107,15 @@
               },
               {
                 "color": "yellow",
-                "value": 70
+                "value": 50
+              },
+              {
+                "color": "orange",
+                "value": 75
               },
               {
                 "color": "red",
-                "value": 85
+                "value": 91.5
               }
             ]
           },
diff --git a/services/monitoring/grafana-dashboard-overview.yaml b/services/monitoring/grafana-dashboard-overview.yaml
index 2ae043e..2cd843b 100644
--- a/services/monitoring/grafana-dashboard-overview.yaml
+++ b/services/monitoring/grafana-dashboard-overview.yaml
@@ -528,7 +528,7 @@ data:
               },
               "mappings": [],
               "thresholds": {
-                "mode": "percentage",
+                "mode": "absolute",
                 "steps": [
                   {
                     "color": "green",
@@ -536,11 +536,15 @@ data:
                   },
                   {
                     "color": "yellow",
-                    "value": 70
+                    "value": 50
+                  },
+                  {
+                    "color": "orange",
+                    "value": 75
                   },
                   {
                     "color": "red",
-                    "value": 85
+                    "value": 91.5
                   }
                 ]
               },
@@ -601,7 +605,7 @@ data:
               },
               "mappings": [],
               "thresholds": {
-                "mode": "percentage",
+                "mode": "absolute",
                 "steps": [
                   {
                     "color": "green",
@@ -609,11 +613,15 @@ data:
                   },
                   {
                     "color": "yellow",
-                    "value": 70
+                    "value": 50
+                  },
+                  {
+                    "color": "orange",
+                    "value": 75
                   },
                   {
                     "color": "red",
-                    "value": 85
+                    "value": 91.5
                   }
                 ]
               },
@@ -810,7 +818,7 @@ data:
               },
               "mappings": [],
               "thresholds": {
-                "mode": "percentage",
+                "mode": "absolute",
                 "steps": [
                   {
                     "color": "green",
@@ -818,11 +826,15 @@ data:
                   },
                   {
                     "color": "yellow",
-                    "value": 70
+                    "value": 50
+                  },
+                  {
+                    "color": "orange",
+                    "value": 75
                   },
                   {
                     "color": "red",
-                    "value": 85
+                    "value": 91.5
                   }
                 ]
               },
@@ -881,7 +893,7 @@ data:
               },
               "mappings": [],
               "thresholds": {
-                "mode": "percentage",
+                "mode": "absolute",
                 "steps": [
                   {
                     "color": "green",
@@ -889,11 +901,15 @@ data:
                   },
                   {
                     "color": "yellow",
-                    "value": 70
+                    "value": 50
+                  },
+                  {
+                    "color": "orange",
+                    "value": 75
                   },
                   {
                     "color": "red",
-                    "value": 85
+                    "value": 91.5
                   }
                 ]
               },
@@ -1731,11 +1747,11 @@ data:
                   },
                   {
                     "color": "orange",
-                    "value": 70
+                    "value": 75
                   },
                   {
                     "color": "red",
-                    "value": 85
+                    "value": 91.5
                   }
                 ]
               }
diff --git a/services/monitoring/grafana-dashboard-storage.yaml b/services/monitoring/grafana-dashboard-storage.yaml
index 1a901e9..8aef820 100644
--- a/services/monitoring/grafana-dashboard-storage.yaml
+++ b/services/monitoring/grafana-dashboard-storage.yaml
@@ -40,7 +40,7 @@ data:
               },
               "mappings": [],
               "thresholds": {
-                "mode": "percentage",
+                "mode": "absolute",
                 "steps": [
                   {
                     "color": "green",
@@ -48,11 +48,15 @@ data:
                   },
                   {
                     "color": "yellow",
-                    "value": 70
+                    "value": 50
+                  },
+                  {
+                    "color": "orange",
+                    "value": 75
                   },
                   {
                     "color": "red",
-                    "value": 85
+                    "value": 91.5
                   }
                 ]
               },
@@ -104,7 +108,7 @@ data:
               },
               "mappings": [],
               "thresholds": {
-                "mode": "percentage",
+                "mode": "absolute",
                 "steps": [
                   {
                     "color": "green",
@@ -112,11 +116,15 @@ data:
                   },
                   {
                     "color": "yellow",
-                    "value": 70
+                    "value": 50
+                  },
+                  {
+                    "color": "orange",
+                    "value": 75
                   },
                   {
                     "color": "red",
-                    "value": 85
+                    "value": 91.5
                   }
                 ]
               },