From 001f0f95a677dfde3062b7d3993a527b9719c5cf Mon Sep 17 00:00:00 2001 From: Brad Stein Date: Sat, 13 Dec 2025 11:51:18 -0300 Subject: [PATCH] atlas pods: fix plurality query with bool max match --- scripts/dashboards_render_atlas.py | 17 ++++++----------- services/monitoring/dashboards/atlas-pods.json | 2 +- services/monitoring/grafana-dashboard-pods.yaml | 2 +- 3 files changed, 8 insertions(+), 13 deletions(-) diff --git a/scripts/dashboards_render_atlas.py b/scripts/dashboards_render_atlas.py index 9a2f84e..a73fd9e 100644 --- a/scripts/dashboards_render_atlas.py +++ b/scripts/dashboards_render_atlas.py @@ -1176,17 +1176,12 @@ def build_pods_dashboard(): table_panel( 10, "Namespace Plurality by Node", - '(' - ' sum by (namespace,node) (kube_pod_info{pod!=""}) ' - '/ sum by (namespace) (kube_pod_info{pod!=""})' - ')' - '* on(namespace) group_left(node)' - '(' - ' (sum by (namespace,node) (kube_pod_info{pod!=""}) ' - ' / sum by (namespace) (kube_pod_info{pod!=""})) ' - '>= on(namespace) group_left() ' - ' (max by (namespace) (sum by (namespace,node) (kube_pod_info{pod!=""}) ' - ' / sum by (namespace) (kube_pod_info{pod!=""})) - 1e-9)' + 'sum by (namespace,node) (kube_pod_info{pod!=""}) ' + '/ sum by (namespace) (kube_pod_info{pod!=""}) ' + '== bool on(namespace) group_left(node) ' + 'max by (namespace) (' + ' sum by (namespace,node) (kube_pod_info{pod!=""}) ' + ' / sum by (namespace) (kube_pod_info{pod!=""})' ')', {"h": 8, "w": 24, "x": 0, "y": 42}, unit="percent", diff --git a/services/monitoring/dashboards/atlas-pods.json b/services/monitoring/dashboards/atlas-pods.json index a9f26c2..b91ee6c 100644 --- a/services/monitoring/dashboards/atlas-pods.json +++ b/services/monitoring/dashboards/atlas-pods.json @@ -508,7 +508,7 @@ }, "targets": [ { - "expr": "( sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / sum by (namespace) (kube_pod_info{pod!=\"\"}))* on(namespace) group_left(node)( (sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / sum by (namespace) (kube_pod_info{pod!=\"\"})) >= on(namespace) group_left() (max by (namespace) (sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / sum by (namespace) (kube_pod_info{pod!=\"\"})) - 1e-9))", + "expr": "sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / sum by (namespace) (kube_pod_info{pod!=\"\"}) == bool on(namespace) group_left(node) max by (namespace) ( sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / sum by (namespace) (kube_pod_info{pod!=\"\"}))", "refId": "A", "instant": true } diff --git a/services/monitoring/grafana-dashboard-pods.yaml b/services/monitoring/grafana-dashboard-pods.yaml index 182885c..0bee968 100644 --- a/services/monitoring/grafana-dashboard-pods.yaml +++ b/services/monitoring/grafana-dashboard-pods.yaml @@ -517,7 +517,7 @@ data: }, "targets": [ { - "expr": "( sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / sum by (namespace) (kube_pod_info{pod!=\"\"}))* on(namespace) group_left(node)( (sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / sum by (namespace) (kube_pod_info{pod!=\"\"})) >= on(namespace) group_left() (max by (namespace) (sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / sum by (namespace) (kube_pod_info{pod!=\"\"})) - 1e-9))", + "expr": "sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / sum by (namespace) (kube_pod_info{pod!=\"\"}) == bool on(namespace) group_left(node) max by (namespace) ( sum by (namespace,node) (kube_pod_info{pod!=\"\"}) / sum by (namespace) (kube_pod_info{pod!=\"\"}))", "refId": "A", "instant": true }