[hermes] bstein_home: python:S2208 #307

New Issue

hermes-automation · 2026-09-24T13:24:37Z

hermes-automation commented

2026-09-24 13:24:37 +00:00

SonarQube reports python:S2208 in backend/atlas_portal/routes/access_requests.py. The build is green; this is a standing finding, not a failure.

What is wrong

The wildcard import makes the facade's imported and re-exported names implicit. Those names also supply the dependency object passed to the route registrars, so removing the re-exports or passing the state module instead could break existing behavior and monkeypatch targets.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Import only needed names or import the module and then use its members. (CRITICAL, 5min estimated) (backend/atlas_portal/routes/access_requests.py:8)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

backend/atlas_portal/routes/access_requests.py — Replace only the wildcard-import line with explicit imports of the complete existing export surface, including names used indirectly through deps. Since access_request_state.py was not supplied, the exact names cannot safely be invented: run this helper from backend in the application's configured environment and use its printed import block as the replacement; do not paste the helper into the facade. Leave all other imports and register() unchanged.

import importlib

state = importlib.import_module("atlas_portal.routes.access_request_state")
try:
    exported_names = state.__all__
except AttributeError:
    exported_names = [name for name in vars(state) if not name.startswith("_")]

print("from .access_request_state import (")
for name in exported_names:
    print(f"    {name} as {name},")
print(")")

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=bstein_home&open=AZ2y3BYyKy9i4pkIpR-L
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_3e358407ac6345c680ed41a2d456c3d5). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S2208** in `backend/atlas_portal/routes/access_requests.py`. The build is green; this is a standing finding, not a failure. ## What is wrong The wildcard import makes the facade's imported and re-exported names implicit. Those names also supply the dependency object passed to the route registrars, so removing the re-exports or passing the state module instead could break existing behavior and monkeypatch targets. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Import only needed names or import the module and then use its members. (CRITICAL, 5min estimated) (`backend/atlas_portal/routes/access_requests.py:8`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`backend/atlas_portal/routes/access_requests.py`** — Replace only the wildcard-import line with explicit imports of the complete existing export surface, including names used indirectly through deps. Since access_request_state.py was not supplied, the exact names cannot safely be invented: run this helper from backend in the application's configured environment and use its printed import block as the replacement; do not paste the helper into the facade. Leave all other imports and register() unchanged. ``` import importlib state = importlib.import_module("atlas_portal.routes.access_request_state") try: exported_names = state.__all__ except AttributeError: exported_names = [name for name in vars(state) if not name.startswith("_")] print("from .access_request_state import (") for name in exported_names: print(f" {name} as {name},") print(")") ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=bstein_home&open=AZ2y3BYyKy9i4pkIpR-L - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_3e358407ac6345c680ed41a2d456c3d5](https://triage.bstein.dev/chat?resume=run_3e358407ac6345c680ed41a2d456c3d5)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bstein/bstein-dev-home#307