[hermes] atlasbot: python:S1871 #47

New Issue

hermes-automation · 2026-09-22T04:23:21Z

hermes-automation commented

2026-09-22 04:23:21 +00:00

SonarQube reports python:S1871 in atlasbot/matrix/bot.py. The build is green; this is a standing finding, not a failure.

What is wrong

In MatrixBot._answer_with_heartbeat's heartbeat() closure, the if snippet and snippet != last_note: branch (line 168) and the elif now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2): branch (line 170) both execute the identical statement should_send = True, so the branch structure adds no differentiation and should be collapsed into one condition.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (atlasbot/matrix/bot.py:170)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

atlasbot/matrix/bot.py — Both conditions lead to the same outcome (should_send = True), which is exactly what S1871 flags. Combining them with or into a single if-statement keeps the truth table identical (should_send is True whenever either condition holds, False otherwise) while removing the duplicated branch body.

should_send = (
                    snippet and snippet != last_note
                ) or now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2)
                if should_send:

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_1178e06f0fee4c2a85a5d37c96cb7b58). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S1871** in `atlasbot/matrix/bot.py`. The build is green; this is a standing finding, not a failure. ## What is wrong In MatrixBot._answer_with_heartbeat's heartbeat() closure, the `if snippet and snippet != last_note:` branch (line 168) and the `elif now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2):` branch (line 170) both execute the identical statement `should_send = True`, so the branch structure adds no differentiation and should be collapsed into one condition. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (`atlasbot/matrix/bot.py:170`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`atlasbot/matrix/bot.py`** — Both conditions lead to the same outcome (should_send = True), which is exactly what S1871 flags. Combining them with `or` into a single if-statement keeps the truth table identical (should_send is True whenever either condition holds, False otherwise) while removing the duplicated branch body. ``` should_send = ( snippet and snippet != last_note ) or now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2) if should_send: ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_1178e06f0fee4c2a85a5d37c96cb7b58](https://triage.bstein.dev/chat?resume=run_1178e06f0fee4c2a85a5d37c96cb7b58)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bstein/atlasbot#47