[hermes] atlasbot: python:S1871 #164

New Issue

hermes-automation · 2026-10-02T11:23:22Z

hermes-automation commented

2026-10-02 11:23:22 +00:00

SonarQube reports python:S1871 in atlasbot/matrix/bot.py. The build is green; this is a standing finding, not a failure.

What is wrong

In the heartbeat loop's should_send computation, the if branch (line 168, triggered when the note snippet changed) and the elif branch (line 170, triggered when the stale-resend interval has elapsed) both just set should_send = True, so the if/elif is doing nothing but OR-ing two conditions through duplicated branch bodies.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (atlasbot/matrix/bot.py:170)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

atlasbot/matrix/bot.py — Collapse the two identical-body branches into a single boolean expression that ORs both conditions, which evaluates to True in exactly the same cases (short-circuiting the same way an if/elif does) without any duplicated branch bodies.

should_send = (snippet and snippet != last_note) or (
                    now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2)
                )
                if should_send:

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_e4214a3b0ea34dd9b31bb8ef9789b9c4). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S1871** in `atlasbot/matrix/bot.py`. The build is green; this is a standing finding, not a failure. ## What is wrong In the heartbeat loop's should_send computation, the if branch (line 168, triggered when the note snippet changed) and the elif branch (line 170, triggered when the stale-resend interval has elapsed) both just set should_send = True, so the if/elif is doing nothing but OR-ing two conditions through duplicated branch bodies. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (`atlasbot/matrix/bot.py:170`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`atlasbot/matrix/bot.py`** — Collapse the two identical-body branches into a single boolean expression that ORs both conditions, which evaluates to True in exactly the same cases (short-circuiting the same way an if/elif does) without any duplicated branch bodies. ``` should_send = (snippet and snippet != last_note) or ( now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2) ) if should_send: ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_e4214a3b0ea34dd9b31bb8ef9789b9c4](https://triage.bstein.dev/chat?resume=run_e4214a3b0ea34dd9b31bb8ef9789b9c4)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bstein/atlasbot#164