[hermes] atlasbot: python:S1871 #161

New Issue

hermes-automation · 2026-09-30T10:22:19Z

hermes-automation commented

2026-09-30 10:22:19 +00:00

SonarQube reports python:S1871 in atlasbot/matrix/bot.py. The build is green; this is a standing finding, not a failure.

What is wrong

In the heartbeat coroutine inside MatrixBot._answer_with_heartbeat, both the if branch (line 168) and the elif branch (line 170) execute the identical statement should_send = True. Sonar's S1871 flags the duplicated branch bodies; the two conditions should be merged into a single boolean expression.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (atlasbot/matrix/bot.py:170)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

atlasbot/matrix/bot.py — The if/elif at lines 167-170 has identical bodies (should_send = True), which is what python:S1871 objects to. Combining the two conditions with 'or' into a single assignment removes the duplicate branches while preserving the exact short-circuit evaluation order and truth conditions: send when the snippet changed, or when the periodic resend interval has elapsed. bool() is applied to the first operand so should_send stays a plain boolean rather than an empty string when snippet is falsy, matching the original False default.

now = time.monotonic()
                should_send = bool(snippet and snippet != last_note) or (
                    now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2)
                )
                if should_send:

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_547553e65c054f0085121956dea34fc8). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S1871** in `atlasbot/matrix/bot.py`. The build is green; this is a standing finding, not a failure. ## What is wrong In the heartbeat coroutine inside MatrixBot._answer_with_heartbeat, both the if branch (line 168) and the elif branch (line 170) execute the identical statement should_send = True. Sonar's S1871 flags the duplicated branch bodies; the two conditions should be merged into a single boolean expression. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (`atlasbot/matrix/bot.py:170`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`atlasbot/matrix/bot.py`** — The if/elif at lines 167-170 has identical bodies (should_send = True), which is what python:S1871 objects to. Combining the two conditions with 'or' into a single assignment removes the duplicate branches while preserving the exact short-circuit evaluation order and truth conditions: send when the snippet changed, or when the periodic resend interval has elapsed. bool() is applied to the first operand so should_send stays a plain boolean rather than an empty string when snippet is falsy, matching the original False default. ``` now = time.monotonic() should_send = bool(snippet and snippet != last_note) or ( now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2) ) if should_send: ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_547553e65c054f0085121956dea34fc8](https://triage.bstein.dev/chat?resume=run_547553e65c054f0085121956dea34fc8)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bstein/atlasbot#161