[hermes] atlasbot: python:S1871 #160

New Issue

hermes-automation · 2026-09-30T02:20:34Z

hermes-automation commented

2026-09-30 02:20:34 +00:00

SonarQube reports python:S1871 in atlasbot/matrix/bot.py. The build is green; this is a standing finding, not a failure.

What is wrong

In the heartbeat coroutine inside MatrixBot._answer_with_heartbeat, the if branch on line 167-168 and the elif branch on line 169-170 both execute the identical statement should_send = True. Sonar flags duplicated branch bodies; the two conditions should be merged into one with or.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (atlasbot/matrix/bot.py:170)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

atlasbot/matrix/bot.py — Merge the two branches that both set should_send = True into a single condition joined by or. Short-circuit evaluation keeps the original ordering (the snippet-changed check runs first, and the elapsed-time check only runs when it fails), so behaviour is unchanged while the duplicate branch body is gone.

now = time.monotonic()
                should_send = False
                if (snippet and snippet != last_note) or now - last_sent >= max(
                    60.0, self._settings.thinking_interval_sec * 2
                ):
                    should_send = True
                if should_send:
                    msg = f"Still thinking — {snippet}…"
                    await self._client.send_message(token, room_id, msg)
                    last_note = snippet
                    last_sent = now

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_52e25e2f08294bceb9e3470323fc9c70). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S1871** in `atlasbot/matrix/bot.py`. The build is green; this is a standing finding, not a failure. ## What is wrong In the heartbeat coroutine inside MatrixBot._answer_with_heartbeat, the if branch on line 167-168 and the elif branch on line 169-170 both execute the identical statement `should_send = True`. Sonar flags duplicated branch bodies; the two conditions should be merged into one with `or`. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (`atlasbot/matrix/bot.py:170`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`atlasbot/matrix/bot.py`** — Merge the two branches that both set `should_send = True` into a single condition joined by `or`. Short-circuit evaluation keeps the original ordering (the snippet-changed check runs first, and the elapsed-time check only runs when it fails), so behaviour is unchanged while the duplicate branch body is gone. ``` now = time.monotonic() should_send = False if (snippet and snippet != last_note) or now - last_sent >= max( 60.0, self._settings.thinking_interval_sec * 2 ): should_send = True if should_send: msg = f"Still thinking — {snippet}…" await self._client.send_message(token, room_id, msg) last_note = snippet last_sent = now ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_52e25e2f08294bceb9e3470323fc9c70](https://triage.bstein.dev/chat?resume=run_52e25e2f08294bceb9e3470323fc9c70)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bstein/atlasbot#160