[hermes] atlasbot: python:S1871 #143

New Issue

hermes-automation · 2026-09-26T20:24:34Z

hermes-automation commented

2026-09-26 20:24:34 +00:00

SonarQube reports python:S1871 in atlasbot/matrix/bot.py. The build is green; this is a standing finding, not a failure.

What is wrong

In the heartbeat coroutine inside MatrixBot._answer_with_heartbeat, the if branch on line 168 and the elif branch on line 170 both execute the identical body should_send = True. SonarQube python:S1871 flags duplicated branch implementations because the split conditions add no behavioural difference and obscure the intent; the two conditions should be merged into one expression.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (atlasbot/matrix/bot.py:170)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

atlasbot/matrix/bot.py — Both branches of the if/elif set should_send = True, so the conditional chain is redundant. Merging the two conditions with or into a single boolean assignment removes the duplicate branch while keeping the exact same truth table: send when the snippet changed, or when the periodic resend interval has elapsed. The bool(...) wrapper keeps should_send a plain boolean even when snippet is an empty string, matching the original False default.

snippet = note[:64]
                now = time.monotonic()
                should_send = bool(snippet and snippet != last_note) or (
                    now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2)
                )
                if should_send:
                    msg = f"Still thinking — {snippet}…"
                    await self._client.send_message(token, room_id, msg)
                    last_note = snippet
                    last_sent = now

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_0d3e593472f74334a0e18b0ed945a719). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S1871** in `atlasbot/matrix/bot.py`. The build is green; this is a standing finding, not a failure. ## What is wrong In the heartbeat coroutine inside MatrixBot._answer_with_heartbeat, the if branch on line 168 and the elif branch on line 170 both execute the identical body `should_send = True`. SonarQube python:S1871 flags duplicated branch implementations because the split conditions add no behavioural difference and obscure the intent; the two conditions should be merged into one expression. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (`atlasbot/matrix/bot.py:170`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`atlasbot/matrix/bot.py`** — Both branches of the if/elif set should_send = True, so the conditional chain is redundant. Merging the two conditions with `or` into a single boolean assignment removes the duplicate branch while keeping the exact same truth table: send when the snippet changed, or when the periodic resend interval has elapsed. The `bool(...)` wrapper keeps should_send a plain boolean even when snippet is an empty string, matching the original False default. ``` snippet = note[:64] now = time.monotonic() should_send = bool(snippet and snippet != last_note) or ( now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2) ) if should_send: msg = f"Still thinking — {snippet}…" await self._client.send_message(token, room_id, msg) last_note = snippet last_sent = now ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_0d3e593472f74334a0e18b0ed945a719](https://triage.bstein.dev/chat?resume=run_0d3e593472f74334a0e18b0ed945a719)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bstein/atlasbot#143