[hermes] atlasbot: python:S1871 #127

New Issue

hermes-automation · 2026-09-24T11:22:24Z

hermes-automation commented

2026-09-24 11:22:24 +00:00

SonarQube reports python:S1871 in atlasbot/matrix/bot.py. The build is green; this is a standing finding, not a failure.

What is wrong

In MatrixBot._answer_with_heartbeat's heartbeat() coroutine, the if/elif at lines 167-170 both execute the identical statement should_send = True, so the two-branch conditional is equivalent to a single combined condition and the duplication is misleading/redundant.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (atlasbot/matrix/bot.py:170)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

atlasbot/matrix/bot.py — Collapse the two branches that both set should_send = True into a single condition using or, preserving the exact same truth table (should_send becomes True if the snippet changed or the resend interval elapsed) while eliminating the duplicate branch body.

should_send = False
                if (snippet and snippet != last_note) or (
                    now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2)
                ):
                    should_send = True

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_ea0c4e66747e4998b8494a23cd6e7432). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S1871** in `atlasbot/matrix/bot.py`. The build is green; this is a standing finding, not a failure. ## What is wrong In MatrixBot._answer_with_heartbeat's heartbeat() coroutine, the if/elif at lines 167-170 both execute the identical statement `should_send = True`, so the two-branch conditional is equivalent to a single combined condition and the duplication is misleading/redundant. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (`atlasbot/matrix/bot.py:170`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`atlasbot/matrix/bot.py`** — Collapse the two branches that both set should_send = True into a single condition using `or`, preserving the exact same truth table (should_send becomes True if the snippet changed or the resend interval elapsed) while eliminating the duplicate branch body. ``` should_send = False if (snippet and snippet != last_note) or ( now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2) ): should_send = True ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_ea0c4e66747e4998b8494a23cd6e7432](https://triage.bstein.dev/chat?resume=run_ea0c4e66747e4998b8494a23cd6e7432)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bstein/atlasbot#127