[hermes] atlasbot: python:S1871 #126

New Issue

hermes-automation · 2026-09-24T10:21:42Z

hermes-automation commented

2026-09-24 10:21:42 +00:00

SonarQube reports python:S1871 in atlasbot/matrix/bot.py. The build is green; this is a standing finding, not a failure.

What is wrong

In the heartbeat() coroutine's inner loop, the if/elif pair both assign should_send = True with no other differing behavior, so the two branches are functionally identical and should be merged into a single condition per the S1871 rule.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (atlasbot/matrix/bot.py:170)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

atlasbot/matrix/bot.py — The if snippet and snippet != last_note: and elif now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2): branches both only execute should_send = True, so they are identical branches per S1871. Combining the two conditions with or into a single if preserves the exact same evaluation order and short-circuiting behavior while eliminating the duplicate branch.

should_send = (
                    (snippet and snippet != last_note)
                    or now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2)
                )

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_5888914dd0f249fa9c8cb7ef61cdcd12). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S1871** in `atlasbot/matrix/bot.py`. The build is green; this is a standing finding, not a failure. ## What is wrong In the heartbeat() coroutine's inner loop, the if/elif pair both assign `should_send = True` with no other differing behavior, so the two branches are functionally identical and should be merged into a single condition per the S1871 rule. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (`atlasbot/matrix/bot.py:170`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`atlasbot/matrix/bot.py`** — The `if snippet and snippet != last_note:` and `elif now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2):` branches both only execute `should_send = True`, so they are identical branches per S1871. Combining the two conditions with `or` into a single if preserves the exact same evaluation order and short-circuiting behavior while eliminating the duplicate branch. ``` should_send = ( (snippet and snippet != last_note) or now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2) ) ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_5888914dd0f249fa9c8cb7ef61cdcd12](https://triage.bstein.dev/chat?resume=run_5888914dd0f249fa9c8cb7ef61cdcd12)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bstein/atlasbot#126