[hermes] atlasbot: python:S1871 #125

New Issue

hermes-automation · 2026-09-24T07:22:18Z

hermes-automation commented

2026-09-24 07:22:18 +00:00

SonarQube reports python:S1871 in atlasbot/matrix/bot.py. The build is green; this is a standing finding, not a failure.

What is wrong

In MatrixBot._answer_with_heartbeat, the if/elif at lines 167-169 both execute the identical statement should_send = True, so the two-branch conditional is really just an OR of the two conditions written as separate branches. This is what S1871 flags: merge them into one condition.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (atlasbot/matrix/bot.py:170)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

atlasbot/matrix/bot.py — The if snippet and snippet != last_note and elif now - last_sent >= max(...) branches both only set should_send = True, so they are the identical-branch case S1871 objects to. Combining them with or keeps the exact same truth table (should_send is True whenever either condition holds, False otherwise, since it defaults to False beforehand) while removing the duplicated branch bodies.

should_send = False
                if (snippet and snippet != last_note) or now - last_sent >= max(
                    60.0, self._settings.thinking_interval_sec * 2
                ):
                    should_send = True

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_e81273a31a324f9c8763274dd606306c). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S1871** in `atlasbot/matrix/bot.py`. The build is green; this is a standing finding, not a failure. ## What is wrong In MatrixBot._answer_with_heartbeat, the if/elif at lines 167-169 both execute the identical statement `should_send = True`, so the two-branch conditional is really just an OR of the two conditions written as separate branches. This is what S1871 flags: merge them into one condition. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (`atlasbot/matrix/bot.py:170`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`atlasbot/matrix/bot.py`** — The `if snippet and snippet != last_note` and `elif now - last_sent >= max(...)` branches both only set `should_send = True`, so they are the identical-branch case S1871 objects to. Combining them with `or` keeps the exact same truth table (should_send is True whenever either condition holds, False otherwise, since it defaults to False beforehand) while removing the duplicated branch bodies. ``` should_send = False if (snippet and snippet != last_note) or now - last_sent >= max( 60.0, self._settings.thinking_interval_sec * 2 ): should_send = True ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_e81273a31a324f9c8763274dd606306c](https://triage.bstein.dev/chat?resume=run_e81273a31a324f9c8763274dd606306c)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bstein/atlasbot#125