[hermes] atlasbot: python:S1871 #120

New Issue

hermes-automation · 2026-09-23T19:21:17Z

hermes-automation commented

2026-09-23 19:21:17 +00:00

SonarQube reports python:S1871 in atlasbot/matrix/bot.py. The build is green; this is a standing finding, not a failure.

What is wrong

In MatrixBot._answer_with_heartbeat's heartbeat() closure, the if/elif at lines 167-170 both set should_send = True in their bodies, so the two branches are functionally identical and only the boolean condition itself differs — SonarQube flags this as duplicate logic that should be collapsed into a single expression.

Ariadne opened no pull request for it: no automated patch was possible for this finding.

Facts

gitea — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (atlasbot/matrix/bot.py:170)

Suggested fix (not applied)

Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch.

atlasbot/matrix/bot.py — Replace the if/elif pair that both assign should_send = True with a single boolean expression combining the two conditions via 'or'. This removes the duplicate branch bodies while leaving should_send's truthiness (and therefore the subsequent 'if should_send:' behavior) identical to before.

should_send = (snippet and snippet != last_note) or (
                    now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2)
                )
                if should_send:

Links

SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI
Full evidence bundle and audit trail live in Ariadne at /api/admin/audit/events, event types hermes_autotriage_incident and hermes_autotriage_diagnosis.

Filed automatically by Ariadne from a Hermes Agent diagnosis (run run_da953c52f1ae4a69b831bc2e9d1dbc7d). Hermes has no write access to this repository; no files or infrastructure were changed.

SonarQube reports **python:S1871** in `atlasbot/matrix/bot.py`. The build is green; this is a standing finding, not a failure. ## What is wrong In MatrixBot._answer_with_heartbeat's heartbeat() closure, the if/elif at lines 167-170 both set should_send = True in their bodies, so the two branches are functionally identical and only the boolean condition itself differs — SonarQube flags this as duplicate logic that should be collapsed into a single expression. Ariadne opened no pull request for it: no automated patch was possible for this finding. ## Facts - **gitea** — Either merge this branch with the identical one on line "168" or change one of the implementations. (MAJOR, 10min estimated) (`atlasbot/matrix/bot.py:170`) ## Suggested fix (not applied) Hermes could not open a pull request for this, so the change below was not written, validated, or pushed anywhere. It is a starting point for whoever picks this up, not a reviewed patch. **`atlasbot/matrix/bot.py`** — Replace the if/elif pair that both assign should_send = True with a single boolean expression combining the two conditions via 'or'. This removes the duplicate branch bodies while leaving should_send's truthiness (and therefore the subsequent 'if should_send:' behavior) identical to before. ``` should_send = (snippet and snippet != last_note) or ( now - last_sent >= max(60.0, self._settings.thinking_interval_sec * 2) ) if should_send: ``` ## Links - SonarQube finding: https://quality.bstein.dev/project/issues?resolved=false&id=atlasbot&open=AZ2y3T24Ky9i4pkIpSiI - Full evidence bundle and audit trail live in Ariadne at `/api/admin/audit/events`, event types `hermes_autotriage_incident` and `hermes_autotriage_diagnosis`. Filed automatically by Ariadne from a Hermes Agent diagnosis (run [run_da953c52f1ae4a69b831bc2e9d1dbc7d](https://triage.bstein.dev/chat?resume=run_da953c52f1ae4a69b831bc2e9d1dbc7d)). Hermes has no write access to this repository; no files or infrastructure were changed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bstein/atlasbot#120