From eb931e8d46ba9b7c4ee393bef8f510a4576dda03 Mon Sep 17 00:00:00 2001
From: Brad Stein <Brad.Stein@gmail.com>
Date: Mon, 13 Apr 2026 01:58:16 -0300
Subject: [PATCH] ci(jenkins): replace weather threshold magic numbers

---
 ariadne/services/jenkins_build_weather.py | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/ariadne/services/jenkins_build_weather.py b/ariadne/services/jenkins_build_weather.py
index 0bcebea..2b6bb9b 100644
--- a/ariadne/services/jenkins_build_weather.py
+++ b/ariadne/services/jenkins_build_weather.py
@@ -95,6 +95,11 @@ _JOB_METRICS = (
     JENKINS_BUILD_WEATHER_JOB_HEALTH_SCORE,
 )
 
+_WEATHER_SUNNY_MIN_SCORE = 80
+_WEATHER_PARTLY_CLOUDY_MIN_SCORE = 60
+_WEATHER_CLOUDY_MIN_SCORE = 40
+_WEATHER_RAINY_MIN_SCORE = 20
+
 
 @dataclass(frozen=True)
 class JenkinsBuildWeatherJob:
@@ -184,13 +189,13 @@ def _health_score(job: dict[str, Any], status: str) -> float:
 def _weather_icon(score: float) -> str:
     if score < 0:
         return "❔"
-    if score >= 80:
+    if score >= _WEATHER_SUNNY_MIN_SCORE:
         return "☀️"
-    if score >= 60:
+    if score >= _WEATHER_PARTLY_CLOUDY_MIN_SCORE:
         return "⛅"
-    if score >= 40:
+    if score >= _WEATHER_CLOUDY_MIN_SCORE:
         return "☁️"
-    if score >= 20:
+    if score >= _WEATHER_RAINY_MIN_SCORE:
         return "🌧️"
     return "⛈️"